Re-pin TypeScript protoc generator. #112
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest build was failing for me locally, I'm not sure how it passed CI.
Hmm, this is weird, I can take a look at this later, we should probably fix this sooner rather than later. |
varungandhi-src
approved these changes
Oct 25, 2022
|
I pushed a commit that should have failed the typecheck job but it succeeded |
olafurpg
force-pushed
the
olafurpg/pin-protoc
branch
from
a97849f
to
e3af21f
Compare
|
Opened a followup issue #113 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest build was failing for me locally, I'm not sure how it passed CI.
Test plan
See the CI go green, and manually verify the job actually builds the TS part