Combine marketing and product homepage #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francisschmaltz
changed the title
New marketing homepageThis branch combines the marketing homepage – currently on about.sourcegraph.com – and the product homepage on sourcegraph.com/search. This solves a problem of users not knowing how to get to our product from our marketing page. This page is only visible on sourcegraph.com and when a no users are signed-in out. A user that is signed-in will get the normal product homepage. |
slimsag
commented
Oct 4, 2018
| @@ -212,15 +212,10 @@ func serveHome(w http.ResponseWriter, r *http.Request) error { | |||
|
|
|||
| if (r.Host == "sourcegraph.com" || r.Host == "www.sourcegraph.com") && !actor.FromContext(r.Context()).IsAuthenticated() { | |||
There was a problem hiding this comment.
@vanesa for having the ability to test, change this line to become:
if envvar.SourcegraphDotComMode() && !actor.FromContext(r.Context()).IsAuthenticated() {
Codecov Report
|
francisschmaltz
pushed a commit
that referenced
this pull request
Oct 5, 2018
New marketing homepage for sourcegraph.com! Router users visiting about.sourcegraph.com/ and sourcegraph.com/ to the new homepage based off the following conditions: If a user is logged out -> / -> /start and gets the new homepage If a user is logged in -> / -> /search and gets the normal search page Users that visit either /start or /search will get the page without redirections This is not implemented on non-sourcegraph.com instances.
francisschmaltz
added a commit
that referenced
this pull request
Oct 5, 2018
* Combine marketing and product homepage (#156) New marketing homepage for sourcegraph.com! Router users visiting about.sourcegraph.com/ and sourcegraph.com/ to the new homepage based off the following conditions: If a user is logged out -> / -> /start and gets the new homepage If a user is logged in -> / -> /search and gets the normal search page Users that visit either /start or /search will get the page without redirections This is not implemented on non-sourcegraph.com instances. * Invert check of sourcegraph.com for 404
felixfbecker
reviewed
Oct 6, 2018
| .layout { | ||
| display: block !important; | ||
| } | ||
| * { |
There was a problem hiding this comment.
This looks like a severe change that could break many things?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from sourcegraph/sourcegraph-intermediate-2018@0df1ccd
fixes https://github.com/sourcegraph/enterprise/issues/13480
cc @francisschmaltz this is your new branch :)