-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up webpack for locally run the website #182
Conversation
@jviotti I am confused about what to do for the failure of "make www" |
Its a linter error:
|
Make www is running fine locally The issue was that, when we run 'make www', as it calls webpack.js which have its own entry point, leading to a conflict with the webpack.config.js file. To address this, I've updated the makefile to directly run the webpack command for building, which handles HTML, JS, and CSS files, while the makefile handles the remaining PNG files. Additionally, I've added the serve command for locally run the website. but i dont know why it getting error in checks 😢 |
May be error is related to the incompatibility of the some webpack dev dependencies on node 16 ( Version in which CI is run) ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I commented on some of the changes that look off. Hopefully that helps, as I'm not a web developer and have very limited Webpack knowledge besides the simple setup I had on this repo
c70c513
to
4f73f99
Compare
dev_Entry.js is the entry file for webpack.config.dev.js. I did this to avoid conflicts with 'make www' command and ensure that 'make www' remains untouched. |
ec685e3
to
ee66a70
Compare
@jviotti, I hope this is okay now. If there are any other changes, please let me know. I learn many good practices from this PR , and I'm really really sorry for this mess !! |
Any time! Looking better already |
I left one remaining comment but other than that works great 👍 |
Signed-off-by: MeastroZI <vinitsharma2480@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
Description:
Implemented webpack configuration for local development and bundling.
Purpose:
To allow the website to run locally and improve the local development environment by configuring webpack for SCSS bundling, import resolution, and output management