Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regex, so that it finds only the package and its subpackages #10

Closed
reka opened this issue Dec 16, 2022 · 1 comment
Closed

Fix regex, so that it finds only the package and its subpackages #10

reka opened this issue Dec 16, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@reka
Copy link
Contributor

reka commented Dec 16, 2022 •
edited
Loading

The currently generated rules also detect imports that are only a text match.

Example

package: core

from statements that should be detected:

  • from core import xx
  • from core.subpackage import yy

from statements that should NOT be detected:

  • from coreasdf import yy
@reka reka added the bug Something isn't working label Dec 16, 2022
@reka
Copy link
Contributor Author

reka commented Dec 16, 2022

https://www.regular-expressions.info/wordboundaries.html

reka added a commit that referenced this issue Dec 16, 2022
@reka
fix: regex in the rule condition fixes #10
9821553 
Example
---------

package: core

from statements that should be detected:

* `from core import xx`
* `from core.subpackage import yy`

from statements that should NOT be detected:

* `from coreasdf import yy`
@reka reka closed this as completed in e9f2f69 Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@reka