Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

have MinHash.seq_to_hashes return None for invalid k-mers #1751

Open
ctb opened this issue Oct 10, 2021 · 0 comments
Open

have MinHash.seq_to_hashes return None for invalid k-mers #1751

ctb opened this issue Oct 10, 2021 · 0 comments

Comments

@ctb
Copy link
Contributor

ctb commented Oct 10, 2021

per #1695 (comment), right now MinHash.seq_to_hashes(...) returns 0 when given an invalid k-mer. This is because I asked that bad k-mers not be skipped so that the index of returned hash values lined up.

However, 0 is a valid hash value :). So on the Python side we would prefer that None be returned, as that is detectably Not Zero.

May be being implemented in #1698, not sure.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ctb