Output unassigned hashes from "gather" to same moltype #1151
Conversation
Codecov Report
@@ Coverage Diff @@
## latest #1151 +/- ##
=========================================
Coverage ? 92.55%
=========================================
Files ? 71
Lines ? 5705
Branches ? 0
=========================================
Hits ? 5280
Misses ? 425
Partials ? 0 Continue to review full report at Codecov.
|
| with_abundance = next_query.minhash.track_abundance | ||
| e = MinHash(ksize=query.minhash.ksize, n=0, max_hash=new_max_hash, | ||
| track_abundance=with_abundance) | ||
| track_abundance=with_abundance, **moltype_kwds) |
There was a problem hiding this comment.
hmm, I'm wondering if it might be possible to create one with a "e = query.minhash.copy_and_clear()" instead, which will clone the attributes of the query MinHash? The only thing I can see being problematic is that you probably want to use new_max_hash instead of the query.minhash.max_hash, in case the signature's been downsampled. Hmm.
There was a problem hiding this comment.
it turns out this wasn't even necessary - next_query is actually the right thing to save directly! w00t!
see #1156
Currently, unassigned hashes are output to a MinHash without a moltype, which means the default is DNA. After testing out
gatheron some protein data and analyzing the output results, turns out the moltype of the input signature is not preserved. This (hopefully) fixes that!make testDid it pass the tests?make coverageIs the new code covered?without a major version increment. Changing file formats also requires a
major version number increment.
changes were made?