-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] fix two bugs in gather --output-unassigned #1156
Conversation
Ready for review @olgabot |
Codecov Report
@@ Coverage Diff @@
## latest #1156 +/- ##
==========================================
+ Coverage 83.72% 92.63% +8.91%
==========================================
Files 95 71 -24
Lines 9012 5692 -3320
==========================================
- Hits 7545 5273 -2272
+ Misses 1467 419 -1048
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you so much! The protein test was a little obtuse to me, so added an explicit line for testing the moltype in the future. I know it's technically already covered by the x.minhash == y.minhash
but it made it easier for me to understand.
Co-authored-by: Olga Botvinnik <olga.botvinnik@gmail.com>
excellent! merging! |
* add test for no unassigned hashes to output with gather * add test for gather --output-unassigned with protein query * fix two bugs in gather --output-unassigned * Update tests/test_sourmash.py Co-authored-by: Olga Botvinnik <olga.botvinnik@gmail.com> Co-authored-by: Olga Botvinnik <olga.botvinnik@gmail.com>
* add test for no unassigned hashes to output with gather * add test for gather --output-unassigned with protein query * fix two bugs in gather --output-unassigned * Update tests/test_sourmash.py Co-authored-by: Olga Botvinnik <olga.botvinnik@gmail.com> Co-authored-by: Olga Botvinnik <olga.botvinnik@gmail.com> Co-authored-by: Olga Botvinnik <olga.botvinnik@gmail.com>
(Stealing #1151 from @olgabot, sorry olga :))
Inspired by #1151, I dug into the
--output-unassigned
code insourmash gather
and found not just the moltype bug in #1151 but also a bug where even fully gather'd inputs would result in saving an (empty) signature file. This PR:--output-unassigned
, fixes Output unassigned hashes from "gather" to same moltype聽#1151--output-unassigned
when the query signature is completely allocated--output-unassigned
to be much simpler 馃槀make test
Did it pass the tests?make coverage
Is the new code covered?without a major version increment. Changing file formats also requires a
major version number increment.
changes were made?