[MRG] Backport fix for molecule type for --output-unassigned to 3.x #1160
+54
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add test for no unassigned hashes to output with gather * add test for gather --output-unassigned with protein query * fix two bugs in gather --output-unassigned * Update tests/test_sourmash.py Co-authored-by: Olga Botvinnik <olga.botvinnik@gmail.com> Co-authored-by: Olga Botvinnik <olga.botvinnik@gmail.com>
|
(I'll merge this if/when the tests pass) |
ctb
changed the title
Codecov Report
@@ Coverage Diff @@
## stable #1160 +/- ##
=========================================
Coverage ? 92.37%
=========================================
Files ? 73
Lines ? 5760
Branches ? 0
=========================================
Hits ? 5321
Misses ? 439
Partials ? 0 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #1156
make testDid it pass the tests?make coverageIs the new code covered?without a major version increment. Changing file formats also requires a
major version number increment.
changes were made?