Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary branch for a metagenome workshop at UCSC #188

Closed
wants to merge 23 commits into from

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Apr 22, 2017

See 2017-ucsc-metagenome.rtfd.io

Contains #183 and #175. Will not merged, although those branches might be :).

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@codecov-io
Copy link

codecov-io commented Apr 22, 2017

Codecov Report

Merging #188 into master will decrease coverage by 0.56%.
The diff coverage is 64.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #188      +/-   ##
==========================================
- Coverage   85.42%   84.85%   -0.57%     
==========================================
  Files          13       13              
  Lines        1894     1922      +28     
  Branches       52       52              
==========================================
+ Hits         1618     1631      +13     
- Misses        265      280      +15     
  Partials       11       11
Impacted Files Coverage Δ
sourmash_lib/signature.py 86.13% <36.36%> (-2.99%) ⬇️
sourmash_lib/sbtmh.py 82.22% <36.84%> (-12.52%) ⬇️
sourmash_lib/commands.py 90.13% <80.39%> (+0.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6609b3a...394e3cb. Read the comment docs.

@ctb
Copy link
Contributor Author

ctb commented May 17, 2017

Closing (but not deleting).

@ctb ctb closed this May 17, 2017
@ctb ctb deleted the 2017-ucsc-metagenome branch June 20, 2020 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants