Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Apply downsampling magic to sbt_search #183

Merged
merged 13 commits into from May 16, 2017
Merged

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Apr 19, 2017

Fixes #146 (a bug in sbt_search). Also fixes #182 (--containment option in search).

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@codecov-io
Copy link

codecov-io commented Apr 19, 2017

Codecov Report

Merging #183 into master will increase coverage by 0.15%.
The diff coverage is 84.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #183      +/-   ##
==========================================
+ Coverage   85.67%   85.83%   +0.15%     
==========================================
  Files          13       13              
  Lines        1906     1934      +28     
  Branches       52       52              
==========================================
+ Hits         1633     1660      +27     
- Misses        262      264       +2     
+ Partials       11       10       -1
Impacted Files Coverage Δ
sourmash_lib/commands.py 90.75% <100%> (+0.66%) ⬆️
sourmash_lib/signature.py 89.6% <100%> (+0.48%) ⬆️
sourmash_lib/sbtmh.py 87.91% <65%> (-6.83%) ⬇️
sourmash_lib/kmer_min_hash.hh 89.14% <0%> (+1.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cd0fe2...211a994. Read the comment docs.

@ctb ctb changed the title [WIP] Apply downsampling magic to sbt_search [MRG] Apply downsampling magic to sbt_search May 14, 2017
@ctb
Copy link
Contributor Author

ctb commented May 14, 2017

Ready for review & merge @luizirber @betatim

Copy link
Member

@luizirber luizirber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@luizirber luizirber merged commit e996f7a into master May 16, 2017
@luizirber luizirber deleted the fix/sbt_search branch May 16, 2017 21:31
@luizirber luizirber added this to Done in sourmash 2.0 May 19, 2017
@luizirber luizirber removed this from Done in sourmash 2.0 May 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants