[MRG] Update documentation with links to new SBTs and a tutorial #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #216 +/- ##
=======================================
Coverage 85.78% 85.78%
=======================================
Files 13 13
Lines 1942 1942
Branches 52 52
=======================================
Hits 1666 1666
Misses 266 266
Partials 10 10Continue to review full report at Codecov.
|
ctb
changed the title
|
Ready for review! |
luizirber
approved these changes
May 16, 2017
doc/tutorials.md
Outdated
|
|
||
| ``` | ||
|
|
||
| ## Fingerprint reads |
There was a problem hiding this comment.
We should stick to one nomenclature: signature or fingerprint?
doc/tutorials.md
Outdated
| wget https://s3.amazonaws.com/public.ged.msu.edu/ecoliMG1655.fa.gz | ||
| ``` | ||
|
|
||
| Compute a scaled MinHash fingerprint from our reads: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be merged after #183 and #175.
Various documentation updates, including:
Note that the this depends on changes in #183 and #175, and so the
pip installneeds to be updated after those are merged; and the URLs for theeschericia-sigs.tar.gzandshakya-unaligned-contigs.sigfiles used in the tutorial should be updated to usemasterbefore merge.make testDid it pass the tests?make coverageIs the new code covered?without a major version increment. Changing file formats also requires a
major version number increment.
changes were made?