Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lots of features and cleanup of command line interface. #56

Merged
merged 1 commit into from
Dec 3, 2016
Merged

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Dec 3, 2016

This contains many useful features that were implemented in #45 but aren't specific to the SBT stuff.

Specifically,

  • add --with-cardinality;
  • sniff gzip/bz2 format signature files;
  • add -n/--num-results to search;
  • more/better printout information;
  • add --name, --name-from-first, and --singleton to sourmash compute
  • make load_signatures into a generator;
  • bump version to 1.1;
  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@codecov-io
Copy link

codecov-io commented Dec 3, 2016

Current coverage is 83.10% (diff: 84.76%)

Merging #56 into master will increase coverage by 0.28%

@@             master        #56   diff @@
==========================================
  Files             8          8          
  Lines           908       1018   +110   
  Methods          37         37          
  Messages          0          0          
  Branches         44         44          
==========================================
+ Hits            752        846    +94   
- Misses          139        155    +16   
  Partials         17         17          

Powered by Codecov. Last update 8005c76...dc736cb

@ctb
Copy link
Contributor Author

ctb commented Dec 3, 2016

The uncovered stuff is mostly error handling, so I'm going to get to it later...

@ctb ctb merged commit d5f77fa into master Dec 3, 2016
@ctb ctb deleted the lotsa_stuff branch December 3, 2016 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants