-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Sequence Bloom Tree-based search into sourmash #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lazy loading hack (5a78330) really speeds things up @luizirber! |
Current coverage is 72.92% (diff: 58.03%)@@ master #45 diff @@
==========================================
Files 9 11 +2
Lines 1106 1869 +763
Methods 38 38
Messages 0 0
Branches 48 48
==========================================
+ Hits 921 1363 +442
- Misses 167 488 +321
Partials 18 18
|
This was referenced Dec 3, 2016
Needs some tests for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes use of @luizirber code from https://github.com/luizirber/2016-sbt-minhash to provid indexing and search subcommands.
Interesting question to ask: should we copy the SBT files into this repo? We could either have the SBT stuff be another project or we could develop it as part of sourmash until we have reason to split it off. Alternatively we could develop the SBT code as part of khmer (again, until we have reason to split).
make test
Did it pass the tests?make coverage
Is the new code covered?without a major version increment. Changing file formats also requires a
major version number increment.
changes were made?