Setting default_site_enabled false does not disable default site on Ubuntu 14.04

[razor-x]

Setting node['apache']['default_site_enabled'] = false does not actually disable the default site on Ubuntu 14.04. (This is on COOK-3900 branch.)

The a2dissite and a2ensite scripts do not correctly add the 000- priority prefix when default is given (even though it seems this functionality is intended).

I am running Ruby 2.1.2 and Vagrant 1.6.3-1 on Arch Linux.

To reproduce:

$ git clone https://gist.github.com/e795303129cc8a5563fa.git
$ cd e795303129cc8a5563fa
$ git checkout ca61368b814fe4f0a79d7c45986021ee17d09c9d
$ bundle
$ kitchen converge
$ kitchen login

Then on the VM:

vagrant@default-ubuntu-1404:/etc/apache2$ ls -l sites-available/
total 16
-rw-r--r-- 1 root root 1332 Jan  7 13:23 000-default.conf
-rw-r--r-- 1 root root 1337 Jun 22 18:22 default
-rw-r--r-- 1 root root 6437 Jan  7 13:23 default-ssl.conf
vagrant@default-ubuntu-1404:/etc/apache2$ ls -l sites-enabled/
total 0
lrwxrwxrwx 1 root root 35 Jun 22 18:22 000-default.conf -> ../sites-available/000-default.conf
vagrant@default-ubuntu-1404:/etc/apache2$ sudo a2dissite default
ERROR: Site default does not exist!
vagrant@default-ubuntu-1404:/etc/apache2$ sudo a2ensite default
ERROR: Site default does not exist!
vagrant@default-ubuntu-1404:/etc/apache2$ sudo a2dissite 000-default
Site 000-default disabled.
To activate the new configuration, you need to run:
  service apache2 reload
vagrant@default-ubuntu-1404:/etc/apache2$ ls sites-enabled/
vagrant@default-ubuntu-1404:/etc/apache2$

[razor-x]

In addition to the issue with the 000-, I think these lines and these lines are also part of the issue.

Specifically, the site config files now end in .conf, but the not_if / only_if tests miss files with that extension (also mentioned in #132):

::File.symlink?("#{node['apache']['dir']}/sites-enabled/#{params[:name]}") ||
::File.symlink?("#{node['apache']['dir']}/sites-enabled/000-#{params[:name]}")

This makes sense as my current workaround is

apache_site '000-default.conf' do
  enable node['apache']['default_site_enabled']
end

[drpebcak]

@razor-x the a2_.erb files that are in the cookbook are only there to recreate some of the capabilities if the ubuntu/debian a2_ commands (meaning the smartness of adding 000- to default only exists there as far as I know). You would have to specify a2dissite 000-default to disable the default site.

I've added .conf to those File.symlink? lines (I actually just added more OR statements to include situations where .conf is not included - for cases where people use apache2.2).

[drpebcak]

@razor-x let me know if the latest commits to https://github.com/drpebcak/apache2/tree/COOK-3900 solves this for you.

[mariomarin]

@drpebcak Using cookbook 'apache2', github: 'drpebcak/apache2', branch: 'COOK-3900' worked. Thank you.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.