Change the service creation to use the service_name attribute throughout #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The service_name attribute was only used to define the service. However, the restart_command and reload_command for rhel had a hardcoded service_name in it. So, for example Software Collections has an apache2.4 rpm package for redhat 6 that installs the httpd service under a different name 'httpd24-httpd'. The recipe would fail at service creation even though I overwrote the service_name attribute.
| when 'debian' | ||
| provider Chef::Provider::Service::Debian | ||
| when 'arch' | ||
| service_name 'httpd' | ||
| service_name apache_service_name |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Previous commit would break arch, so I defaulted the service_name to httpd
svanzoest
added a commit
that referenced
this pull request
Jul 1, 2015
Change the service creation to use the service_name attribute throughout
|
Thanks! |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The service_name attribute was only used to define the service. However,
the restart_command and reload_command for rhel had a hardcoded service_name
in it. So, for example Software Collections has an apache2.4 rpm package for
redhat 6 that installs the httpd service under a different name 'httpd24-httpd'.
The recipe would fail at service creation even though I overwrote the service_name
attribute.