Fixes to attributes #453
Fixes to attributes #453
Conversation
Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
Even releases that have been EOL’d are 2.4 Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
I’m fairly certain this was a typo and it was meant to be 8 since PHP7 is in 8. Also this needs to be .to_i to make it ever work Signed-off-by: Tim Smith <tsmith@chef.io>
| @@ -17,7 +17,7 @@ | |||
| # limitations under the License. | |||
| # | |||
|
|
|||
| define :apache_module, :enable => true, :conf => false, :restart => false do # rubocop:disable Metrics/BlockLength | |||
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| @@ -25,7 +25,7 @@ | |||
| Chef::Log.warn("Currently the apache2 cookbook is configured to use the '#{node['apache']['mpm']}' MPM") | |||
| end | |||
|
|
|||
| case node['platform_family'] # rubocop:disable Style/MultilineIfModifier | |||
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| @@ -80,8 +80,8 @@ | |||
| default['apache']['default_site_name'] = 'default' | |||
|
|
|||
| # Where the various parts of apache are | |||
| case node['platform'] | |||
| when 'redhat', 'centos', 'scientific', 'fedora', 'amazon', 'oracle' | |||
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| @@ -48,9 +48,9 @@ | |||
| when 'ubuntu' | |||
| node['platform_version'].to_f >= 13.10 ? '2.4' : '2.2' | |||
| when 'linuxmint' | |||
| node['platform_version'].to_i >= 16 ? '2.4' : '2.2' | |||
| node['platform_version'].to_i >= 16 ? '2.4' : '2.2' # this can go away 4/17 | |||
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Some code optimizations and bug fixes in the attributes