Replace hosts_file cookbook dependency with hostsfile cookbook #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epierotto
reviewed
Sep 30, 2016
| hostsfile_entry ip do | ||
| hostname host | ||
| unique false | ||
| notifies :restart, 'service[dnsmasq]', :delayed |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
Really we should require Chef 14+ and be done with it since we have a built in resource for setting hostnames now. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing this cookbook and the managed_hosts recipe I saw that the resources were created and apparently run as part of the chef converge, however they never actually updated my hosts file! I have replaced the
hosts_filecookbook dependency with thehostsfilecookbook which has never failed me in the past.Hopefully you don't find this to be an offensive PR as I know you guys wrote the
hosts_filecookbook.