Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolved multiple issues found during testing, added backwards compatibility #96

Merged
merged 27 commits into from
Jan 14, 2015
Merged

Resolved multiple issues found during testing, added backwards compatibility #96

merged 27 commits into from
Jan 14, 2015

Conversation

EasyAsABC123
Copy link
Contributor

Bug Fixes for:
#95
#98
#100
#99
#101

had to remove unneeded variables
incorrect variables
add dependencies
bumped version
added backwards compatibility for chef-client < 12.x.x Chef::Util::PathHelper
fixed bindings

Justin Schuhmann and others added 16 commits December 22, 2014 11:35
resolve issue with class breaking
a5c067d 
TypeError

wrong argument type Class (expected Module)
fixes issue with class type error compile
80992ae
updated to mention chef 11.4.X requirement
05fb055
bumped version for minor hotfix
f3475e6
fixes issues with namespacing using class
a33a90a 
this resolved multiple use cases and issues with namespacing libraries with class instead of module.
updated
7e01123
fixed issue with site_identifier
891ef9f
@EasyAsABC123
Merge pull request #29 from EasyAsABC123/hotfix_helper-class
50ed5ed 
Hotfix helper class
fixed issues with variable names
016f9f3
@EasyAsABC123
Merge pull request #30 from EasyAsABC123/hotfix_helper-class
d1316c3 
fixed issues with variable names
bumped version
f4f0cbc
@EasyAsABC123
Merge pull request #31 from EasyAsABC123/hotfix_helper-class
8b3f9e8 
bumped version
updated to fix bindings in iis_site
335466a 
added example for readme
@EasyAsABC123
Merge pull request #33 from EasyAsABC123/hotfix_helper-class
652b911 
updated to fix bindings in iis_site
attempt to make backwards compatible
41246ad
fixed noMethodFound for cleanpath
6f9c1fe
@EasyAsABC123 EasyAsABC123 changed the title Resolved https://github.com/opscode-cookbooks/iis/issues/95 Resolved multiple issues found during testing, added backwards compatibility Jan 2, 2015
This was referenced Jan 2, 2015
Closed
Closed
This was referenced Jan 5, 2015
Closed
Closed
@EasyAsABC123 EasyAsABC123 mentioned this pull request Jan 6, 2015
Closed
@EasyAsABC123
Copy link
Contributor Author

Paging @adamedx, @btm, @jdmundrawala and @jtimberman

Ready for Code Review from a testing standpoint.

@smurawski
Copy link
Contributor

Working through it now @EasyAsABC123

@jaym
Copy link

jaym commented Jan 13, 2015

I think @smurawski said he was going to be taking a look at PRs here today

@EasyAsABC123
Copy link
Contributor Author

@jdmundrawala thanks
@smurawski Thanks, I forgot who I spoke to yesterday. 👍

smurawski
smurawski reviewed Jan 13, 2015
View reviewed changes
metadata.rb
supports "windows"
depends "windows", ">= 1.34.6"
depends "chef-client", ">= 3.7.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the additional dependency? I don't see OpsCode::ChefClient::Helpers or any of the recipes used.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought that was required for Chef::Util::PathHelper, is this incorrect?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, PathHelper is in core chef-client, not the cookbook.

@smurawski
Copy link
Contributor

@EasyAsABC123 Would you mind fixing the encoding on README.md? It's set as UTF-8 and showing as a binary file.

@EasyAsABC123
Copy link
Contributor Author

@smurawski I Saved the file as UTF-8 but it isn't showing as a change occurring.

@smurawski
Copy link
Contributor

Yeah, github can be picky about that.. Re-encode as ASCII or make sure there is no BOM?

@smurawski
Copy link
Contributor

Otherwise, it's looking pretty good. So, remove the dependency on the chef-client cookbook and fix the file encoding on the README.md and I'll be happy to merge it.

EasyAsABC123 and others added 2 commits January 13, 2015 15:17
@EasyAsABC123
Update README.md
73692a4
Bumped to version 3.0.10
30738a6 
resolved issues
- Removed dependency on "chef-client", ">= 3.7.0"
- Changed all files to UTF-8 file format
@EasyAsABC123
Copy link
Contributor Author

@smurawski I think I fixed the issue of encoding, also removed the dependency

smurawski added a commit that referenced this pull request Jan 14, 2015
@smurawski
Merge pull request #96 from EasyAsABC123/hotfix_helper-class
0f34f8d 
Resolved multiple issues found during testing, added backwards compatibility.
Resolves #95
Resolves #98
Resolves #99
Resolves #100
Resolves #101
@smurawski smurawski merged commit 0f34f8d into sous-chefs:master Jan 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EasyAsABC123 @smurawski @jaym