Switch to bracket syntax for node attributes #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now we're using strings all over (I think at least). Need to run through the integration tests to make sure that nothing explodes unexpectedly. |
mthssdrbrg
force-pushed
the
bracket-syntax
branch
from
681d81b
to
e925ba7
Compare
Apparently method access (node.foo.bar) is deprecated and will be removed in Chef 13, and newer versions of Chef produce a large deprecation warning when anything else than bracket syntax is used.
mthssdrbrg
force-pushed
the
bracket-syntax
branch
from
e925ba7
to
451e7ba
Compare
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out in #104, method access (
node.foo.bar) is deprecated and will be removed in Chef 13, and newer versions of Chef produce a large deprecation warning when anything else than bracket syntax is used.I need to have a look at the tests as well (to stay consistent).