Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node search in galera setup results in excessive log output #90

Closed
explody opened this issue Oct 23, 2015 · 2 comments
Closed

Node search in galera setup results in excessive log output #90

explody opened this issue Oct 23, 2015 · 2 comments
Assignees
Milestone

Comments

@explody
Copy link

explody commented Oct 23, 2015

In galera.rb, after the node search is done, this snippet outputs a log entry (line ~69)

    log 'Chef search results' do
      message "Searching for \"#{node['mariadb']['galera']['cluster_search_query']}\" \
        resulted in \"#{galera_cluster_nodes}\" ..."
    end

Which results in the array of galera_cluster_nodes being dumped into the log, including the full structure of node attributes - over 200K of text in our case.

It's possible that we could suppress this with log level tweaking but I'm not sure that 200K of unformatted ruby hash would ever be useful in a log file - plus it could lead to a sensitive data leak depending on what's in the node attributes.

@shoekstra shoekstra self-assigned this Mar 8, 2017
@shoekstra shoekstra added this to the v1.1.0 milestone Mar 8, 2017
@shoekstra
Copy link
Contributor

This has been moved to the debug log, so you shouldn't see this anymore.

jfwm2 pushed a commit to jfwm2/mariadb that referenced this issue Apr 4, 2017
@lock
Copy link

lock bot commented Jul 24, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants