Correct GRANTS management bugs #236 & #243 #255
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinfomicien
force-pushed
the
correct-privileges-grant
branch
from
446c67b
to
58446f2
Compare
dud225
reviewed
Apr 12, 2019
| @@ -245,15 +245,19 @@ def revokify_key(key) | |||
|
|
|||
| # Repair | |||
| if incorrect_privs | |||
| privileges_to_set = new_resource.privileges.map { |key| clean_grant_name(key) } | |||
There was a problem hiding this comment.
I've not tested my PR against a RDS database, but this one won't work to my mind. In this specific case my PR better handles it by working with desired_privs instead of new_resource.privileges.
see here for more details
|
@sinfomicien I am happy to merge this one if you say it's all good mate, the tests are broken totally at the moment but wanting to get merges in anyway |
xorima
added
Bug
|
Hey @sinfomicien Do you want me to just merge this one in (Trying to close down all our old PRs mate 👍) |
Closing due to inactivity.If this is still an issue please reopen or open another PR. Alternatively drop by the #sous-chefs channel on the Chef Community Slack and we'll be happy to help! Thanks, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Correct GRANT management
Issues Resolved
[#236]
[#243]
Check List