Removing newline character at end of export_line #95
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed because in the "line" cookbook resource "replace_or_add", the value for line is compared to the existing line in the /etc/exports file, but modified with .chomp
So, when "new_resource.line" ends with a '\n' character, it will never be equal to line.chomp, so it will always be marked as modified = true. When modified is set to true, the resource is declared as updated by the last action, so the line
notifies :run, 'execute[exportfs]', :immediately
will notify execute[exportfs] everytime, even if there was no update to the line.