Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't write an empty pid_file attribute #67

Merged
merged 1 commit into from
Jul 13, 2017

Conversation

sspans
Copy link
Contributor

@sspans sspans commented Jul 13, 2017

Systemd doesn't require a pid-file so it might be useful to skip writing this attribute.
This change makes it the attribute fully configurable.

Description

This change makes the pid_file attribute optional.

Issues Resolved

It wasn't possible to run nrpe without a pid_file.
NRPE fails when the pid_file option is configured but empty.

Check List

Systemd doesn't require a pid-file so it might be useful to skip writing this attribute.
This change makes it the attribute fully configurable.
@shoekstra shoekstra merged commit 46f4c94 into sous-chefs:master Jul 13, 2017
@shoekstra shoekstra added the bug label Jul 13, 2017
@lock
Copy link

lock bot commented Jul 24, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants