Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using libgdm6 when Debian 10.0 #255

Merged
merged 12 commits into from
Jul 17, 2019

Conversation

dormi
Copy link

@dormi dormi commented Jul 12, 2019

Description

When running rbenv_ruby 2.4.1 on a chef recipe in Debian 10.0, I got:

* ruby_rbenv_plugin[ruby-build] action install
* git[Install ruby-build plugin] action sync (up to date)
   (up to date)
* apt_package[gcc, autoconf, bison, build-essential, libssl-dev, libyaml-dev, libreadline6-dev, zlib1g-dev, libncurses5-dev, libffi-dev, libgdbm3, libgdbm-dev, make] action install
* No candidate version available for libgdbm3
 ================================================================================
 Error executing action `install` on resource 'apt_package[gcc, autoconf, bison, build-essential, libssl-dev, libyaml-dev, libreadline6-dev, zlib1g-dev, libncurses5-dev, libffi-dev, libgdbm3, libgdbm-dev, make]'
 ================================================================================
 
 Chef::Exceptions::Package
 -------------------------
 No candidate version available for libgdbm3

This PR tries to use libdgm6 on Debian 10, which seems to work.

Issues Resolved

#254

Contribution Check List

  • All tests pass.
  • New functionality includes testing.
  • New functionality has been documented in the README if applicable

This change is Reviewable

xorima and others added 8 commits May 4, 2019 19:43
This commit will update the readme
This commit will standardise the dangerfile and bring it in line with all other repositories
This commit adds information about us, the maintainers, and how to contact us on slack/ our website
This commit enables us to accept the chef license inside dokken
@dormi dormi requested a review from a team July 12, 2019 10:42
@kitchen-porter
Copy link
Contributor

kitchen-porter commented Jul 12, 2019

1 Warning
⚠️ This Pull Request is probably missing tests.

Generated by 🚫 Danger

@damacus
Copy link
Member

damacus commented Jul 17, 2019

Hey,

thanks for the PR, can you update your PR with feedback from kitchen-porter and the linting errors please?

Thanks!
Dan

@dormi
Copy link
Author

dormi commented Jul 17, 2019

Hi @damacus. I am having problems detecting the lint errors.
Where/how can I see them?

@damacus
Copy link
Member

damacus commented Jul 17, 2019

Ah it's just below the last comment in the Github UI. Hitting "Details" will take you to CircleCI.

Which I just did and have realised we're on an old CircleCI orb which is causing the error. I'll get that fixed up so you can rebase on something sensible. Sorry about that!

With 70+ repos there's always something needing updating!

@damacus damacus changed the base branch from master to debug-circleci-failures July 17, 2019 15:50
@damacus damacus merged commit d080f41 into sous-chefs:debug-circleci-failures Jul 17, 2019
@damacus
Copy link
Member

damacus commented Jul 17, 2019

Fixed! thank you for this, I'll get this released shortly.

@dormi
Copy link
Author

dormi commented Aug 6, 2019

@damacus a 2.1.3 version was released, but does not contain this libgdm6 update?

@dormi
Copy link
Author

dormi commented Aug 28, 2019

^ ping @damacus

@francocatena
Copy link
Contributor

I get this error too, aparently the fix is not released because it is in another branch (debug-circleci-failures).

Presumibly it needs some love, but the problem is we can not get this working on Debian 10 since there is no way around it if not released.

There is something we can do to help this?

@lock
Copy link

lock bot commented Oct 4, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants