Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scoped class helper #21

Merged
merged 6 commits into from
Apr 19, 2023
Merged

Scoped class helper #21

merged 6 commits into from
Apr 19, 2023

Conversation

candunaj
Copy link
Contributor

This PR

  • refactor everything to module
  • implements scopedClass function. That function can be used in tests for generating scoped classes as in the following example.
import { scopedClass } from 'ember-scoped-css/test-helper';

const renamedClass = scopedClass('some-class', 'src/components/some-component.css');

mansona
mansona approved these changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'm happy for you to merge once the tests pass

@mansona mansona merged commit 0957c7b into main Apr 19, 2023
@mansona mansona deleted the scoped-class-helper branch April 19, 2023 14:01
@mansona mansona added the enhancement New feature or request label Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mansona mansona mansona approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@candunaj @mansona