-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a lint rule for the correct usage of scoped-class helper #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mansona
suggested changes
May 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few changes before we can merge. I feel like we also need a documentation section about adding this rule too but I know we're blocked on merging the readme 🙈
candunaj
force-pushed
the
ember-scoped-error-message
branch
2 times, most recently
from
May 2, 2023 11:30
865af02
to
9d2190f
Compare
candunaj
force-pushed
the
ember-scoped-error-message
branch
from
May 2, 2023 11:34
9d2190f
to
f6f3a5e
Compare
mansona
suggested changes
May 2, 2023
Co-authored-by: Chris Manson <mansona@users.noreply.github.com>
Co-authored-by: Chris Manson <mansona@users.noreply.github.com>
mansona
approved these changes
May 2, 2023
mansona
changed the title
Make sure devs are informed of incorrect use of ember-scoped-css
Add a lint rule for the correct usage of scoped-class helper
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new ember-template-lint rule for
(scoped-class "some-class")
helper was implemented to improve the developer experience.