Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a lint rule for the correct usage of scoped-class helper #26

Merged
merged 6 commits into from
May 2, 2023

Conversation

candunaj
Copy link
Contributor

@candunaj candunaj commented May 2, 2023

A new ember-template-lint rule for (scoped-class "some-class") helper was implemented to improve the developer experience.

@candunaj candunaj requested a review from mansona May 2, 2023 10:44
Copy link
Contributor

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes before we can merge. I feel like we also need a documentation section about adding this rule too but I know we're blocked on merging the readme 🙈

ember-scoped-css/package.json Outdated Show resolved Hide resolved
ember-scoped-css/test/scoped-class-helper.js Outdated Show resolved Hide resolved
ember-scoped-css/test/scoped-class-helper.js Outdated Show resolved Hide resolved
ember-scoped-css/test/scoped-class-helper.js Outdated Show resolved Hide resolved
@candunaj candunaj force-pushed the ember-scoped-error-message branch 2 times, most recently from 865af02 to 9d2190f Compare May 2, 2023 11:30
@candunaj candunaj force-pushed the ember-scoped-error-message branch from 9d2190f to f6f3a5e Compare May 2, 2023 11:34
@candunaj candunaj requested a review from mansona May 2, 2023 11:35
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
candunaj and others added 2 commits May 2, 2023 14:37
Co-authored-by: Chris Manson <mansona@users.noreply.github.com>
Co-authored-by: Chris Manson <mansona@users.noreply.github.com>
@mansona mansona changed the title Make sure devs are informed of incorrect use of ember-scoped-css Add a lint rule for the correct usage of scoped-class helper May 2, 2023
@mansona mansona added the enhancement New feature or request label May 2, 2023
@candunaj candunaj merged commit 6fd19be into main May 2, 2023
@candunaj candunaj deleted the ember-scoped-error-message branch May 2, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants