Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix naming of rollup plugins and helper functions in ember-scoped-css #31

Merged
merged 3 commits into from
May 16, 2023

Conversation

candunaj
Copy link
Contributor

@candunaj candunaj commented May 16, 2023

Renamed some helper functions.
Exposed only one unplugin scoped-css-unplugin. It will be easier to use in applications.

import { scoped-css-unplugin } from 'ember-scoped-css';

export default defineConfig({
 plugins: [
  ...,
  addon.keepAssets(...),
+  scopedCssUnplugin.rollup(),
]
});

@candunaj candunaj marked this pull request as ready for review May 16, 2023 08:04
Copy link
Contributor

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🎉

@candunaj candunaj merged commit b33d3eb into main May 16, 2023
@candunaj candunaj deleted the rename-functions branch May 16, 2023 09:22
@candunaj candunaj added enhancement New feature or request breaking labels May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants