Support for classic apps #33
Conversation
| let htmlbarsPlugin = plugins.find( | ||
| (p) => p._parallelBabel?.params?.templateCompilerPath | ||
| ); |
There was a problem hiding this comment.
Do we think this is good enough to identify the htmlbars plugin? there are no other more specific ways to find this?
|
|
||
| let customPlugin = [require.resolve('../dist/scoped-babel-plugin.cjs')]; | ||
|
|
||
| plugins.splice(htmlbarsPluginIndex - 1, 0, customPlugin); |
There was a problem hiding this comment.
does this break if htmlbarsPlugin is the first in the list?
| let htmlbarsPlugin = plugins.find( | ||
| (p) => p._parallelBabel?.params?.templateCompilerPath | ||
| ); | ||
| if (htmlbarsPlugin) { |
There was a problem hiding this comment.
do we not need an else with this if?
There was a problem hiding this comment.
Not sure how it could happen. I believe, that the plugin has to be there in every application.
| let preprocessors = registry.load('css'); | ||
| preprocessors.forEach((p) => registry.remove('css', p)); | ||
| this.outputStylePreprocessor.preprocessors = preprocessors; | ||
| registry.add('css', this.outputStylePreprocessor); |
There was a problem hiding this comment.
Maybe add a comment ahead of this to explain that we needed to make sure that we run ours first (and that we couldn't find any ember-cli way to make it happen first)
There was a problem hiding this comment.
Thank you for suggestion
| // ignore css files for ember-css-modules | ||
| if (relativePath.endsWith('.module.css')) { | ||
| return ''; | ||
| } |
There was a problem hiding this comment.
I feel like this needs to be configurable 🤔 since ember-css-modules could be configured with anything
This PR adds support for classic apps.
CSS files are rewritten by css preprocessor.
A babel plugin rewrites templates.