Fix comparing _EOF with itself #20
Conversation
tests/test_eof.py
Outdated
| from dahuffman.huffmancodec import _EOF | ||
|
|
||
|
|
||
| def test_eq(): |
There was a problem hiding this comment.
I don't think it's necessary to put these tests in a separate file.
I would just add them in the existing test_dahuffman.py file
Maybe move the tests and fixtures inside a class, e.g. TestEndOfFileSymbol. I'm guessing you used a separate file to keep the fixtures away from existing tests, but you can also achieve that by scoping them to a single class
tests/test_eof.py
Outdated
|
|
||
|
|
||
| @pytest.fixture | ||
| def to_compare(raw_value, of_type): |
There was a problem hiding this comment.
I feel this construct of three fixtures is a bit convoluted and misses some useful things to test against.
I would just make a straight list of values to use, e.g.
[
b"\0",
b"abc",
"abc",
0,
100,
-1000,
False,
True,
None,
[],
(),
{},
[-100, 0, 10],
(-100, 10),
_EndOfFileSymbol()
]
Co-authored-by: Stefaan Lippens <soxofaan@gmail.com>
| class TestEndOfFileSymbol: | ||
|
|
||
| def test_eq(self): | ||
| assert _EOF == _EOF |
There was a problem hiding this comment.
maybe also test equality _EOF == _EndOfFileSymbol()
| [-100, 0, 10], | ||
| (-100, 10)) | ||
| ) | ||
| def to_compare(request): |
There was a problem hiding this comment.
What I meant in a previous comment was pytest allows you to define the fixture as a method of TestEndOfFileSymbol (instead of a module level function), which makes it available only to other methods of that class
| assert _EOF < to_compare | ||
|
|
||
| def test_gt(self, to_compare): | ||
| assert to_compare > _EOF |
There was a problem hiding this comment.
I would also assert for !=, and maybe just put everything in same test function to keep it simple:
assert _EOF < to_compare
assert _EOF <= to_compare
assert to_compare > _EOF
assert to_compare >= _EOF
assert to_compare != _EOF
assert not (to_compare == _EOF)
Changes
__lt__and__gt__to use equality checkCode quality tasks:
flake8steps specified in.github/workflows/lint-and-test.yml[(https://github.com/pushfoo/python-dahuffman/blob/93d9e7b73e7582b9651ab567a69b3ac1c3cb624e/.github/workflows/lint-and-test.yml#L36-L38)