Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: xdiskusage-like layout made of vertical columns instead of horizontal bars #17

Open
zivanfi opened this issue Sep 10, 2022 · 2 comments

Comments

@zivanfi
Copy link

zivanfi commented Sep 10, 2022

Hi,

I really like that with duviz I can have hierarchical disk usage visualization in a terminal, but I prefer the left-to-right layout of xdiskusage:

xdiskusage

It would be nice to have a similar layout available in duviz. I created an implementation for this that you can use if you like. It looks like this:

duviz-columns

In color mode:

duviz-columns-colored

@soxofaan
Copy link
Owner

Interesting, Thanks for the PR (I hope I can find some time to give it a proper review).

I'd like to point out however that I explicitly chose the top-to-bottom based visualization because it is more space efficient and you have much fewer cases of trimmed labels where it is important (the big blocks)

@zivanfi
Copy link
Author

zivanfi commented Sep 23, 2022

Hmm, funnily my reason for preferring the left-to-right layout is also label trimming. :) While the top levels clearly allow longer labels in the top-to-bottom layout, I often find that many blocks on lower levels trim the label too much while with the left-to-right layout every block gets enough label space unless it is so insignificant that it does not even take up a single line.

In any case, this is clearly a question of personal preference and I understand if you prefer the top-to-bottom layout. You may still consider this PR in this case too, just to allow the end user to make their own choice of preference. On the other hand, accepting this contribution could put maintenance burden on you in the future, so I understand if you decide to prefer the simplicity of the code base over a wider feature-set.

zivanfi added a commit to zivanfi/duviz that referenced this issue Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants