Feat/marshaller #69
Closed
Feat/marshaller #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
soyuka
commented
Jan 30, 2023
soyuka
commented
| Q | A |
|---|---|
| Branch? | main for features / current stable version branch for bug fixes |
| Bug fix? | yes/no |
| New feature? | yes/no |
| Deprecations? | yes/no |
| Tickets | Fix #... |
| License | MIT |
| Doc PR | api-platform/docs#... |
soyuka
commented
Jan 30, 2023
|
|
||
| $context = new Context( | ||
| new TypeOption( | ||
| gettype($controllerResult) |
There was a problem hiding this comment.
Suggested change
| gettype($controllerResult) | |
| get_class($controllerResult) |
| ); | ||
|
|
||
| $input = new InputStream(); | ||
| fwrite($input->resource(), json_encode($data)); |
| $dataDeserialized = $this->marshaller->unmarshal( | ||
| $input, | ||
| AttributeResource::class, | ||
| 'json', |
| $event->setResponse(new Response( | ||
| $controllerResult, | ||
| if( | ||
| \gettype($controllerResult) === 'string' |
Byidi
force-pushed
the
feat/marshaller
branch
2 times, most recently
from
815fc71
to
d7e00c5
Compare
soyuka
commented
Feb 7, 2023
|
|
||
| return new AttributeResources(new AttributeResource(1, 'Foo'), new AttributeResource(2, 'Bar')); | ||
| return new Collection(new AttributeResource(1, 'Foo'), new AttributeResource(2, 'Bar')); |
soyuka
commented
Feb 7, 2023
| ? \gettype($controllerResult) | ||
| : \get_class($controllerResult) | ||
| ), | ||
| ); |
There was a problem hiding this comment.
todo: remove this
- add a proxy for @id etc.
soyuka
commented
Feb 7, 2023
| } | ||
|
|
||
| return $resource; | ||
| return new AttributeResource($uriVariables['identifier'], 'Foo'); |
soyuka
force-pushed
the
3.1
branch
3 times, most recently
from
ae6649e
to
0a362d3
Compare
soyuka
force-pushed
the
3.1
branch
3 times, most recently
from
6d03ee5
to
412d5b2
Compare
soyuka
force-pushed
the
3.1
branch
5 times, most recently
from
d2dbe99
to
cad9e4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.