Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There is no interval.unref in Electron #109

Closed
lierdakil opened this issue May 16, 2020 · 1 comment · Fixed by #110
Closed

There is no interval.unref in Electron #109

lierdakil opened this issue May 16, 2020 · 1 comment · Fixed by #110
Assignees
@soyuka
Labels
bug

Comments

@lierdakil
Copy link

pidusage/lib/history.js

Line 42 in b52a86c

interval.unref()

This line breaks compatibility with Electron apps, which uses Chromium-provided setTimeout/setInterval instead of Node's implementations.

Perhaps a reasonable band-aid is to check if unref function exists before invoking it?
@lierdakil lierdakil mentioned this issue May 16, 2020
Open
@simonepri simonepri added the bug label May 18, 2020
@simonepri
Copy link
Collaborator

simonepri commented May 18, 2020 •
edited
Loading

@lierdakil Would you mind submitting a PR?

I think checking before invocation is fine.

soyuka added a commit that referenced this issue May 19, 2020
@soyuka
fix #109
badac91
@soyuka soyuka mentioned this issue May 19, 2020
Merged
soyuka added a commit that referenced this issue May 19, 2020
@soyuka
Merge pull request #110 from soyuka/fix-109
73e8be6 
Fix #109
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@soyuka soyuka

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #109 soyuka/pidusage
3 participants
@soyuka @simonepri @lierdakil