Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Username bans #19563

Open
Tracked by #23246
Chief-Engineer opened this issue Aug 26, 2023 · 2 comments · May be fixed by #32535
Open
Tracked by #23246

Username bans #19563

Chief-Engineer opened this issue Aug 26, 2023 · 2 comments · May be fixed by #32535
Labels
Issue: Feature Request This issue is a feature request. Priority: 1-Urgent GET ON IT STAT

Comments

@Chief-Engineer
Copy link
Contributor

WizDen currently deals with bad usernames by placing an account ban, but since you can easily change usernames now this is not ideal. There are two primary purposes which should be served:

Preemptive bans

In this use case, multiple blacklist regex are defined. Unlike notes and bans, these are likely to be modified frequently, at least in the time around their initial creation, so it may be beneficial to keep that in mind when designing a way to audit the changes. This would also benefit from a whitelist system, where specific usernames are provided that will be permitted even if they match a blacklist regex. Neither the regex blacklist nor the username whitelist strictly require the ability for admins to interact with them in-game, interaction through SS14.Admin is probably ideal.

Reactive bans

In this use case, a player joins with a username that the game admins want to ban, so the specific player's username is blacklisted. This should be possible in-game.

Ban message

The ban message for a username blacklist should probably be configurable, and each blacklist entry should probably have the ability to have a note added to it, especially regex blacklists, but a public per username ban reason is probably not needed. Players that hit a username ban should just be clearly told that their username isn't permitted and they can change it at (link) or appeal at (link).

@Chief-Engineer Chief-Engineer added Priority: 2-Before Release This needs to be fixed before release, but is not an immediate issue Issue: Feature Request This issue is a feature request. labels Aug 26, 2023
@ShadowCommander ShadowCommander added Priority: 1-Urgent GET ON IT STAT and removed Priority: 2-Before Release This needs to be fixed before release, but is not an immediate issue labels Mar 19, 2024
@benev0 benev0 linked a pull request Sep 29, 2024 that will close this issue
10 tasks
@benev0
Copy link
Contributor

benev0 commented Oct 6, 2024

Should the regex username ban have the functionality to auto extend into a full ban? In cases in witch a regex ban is significant enough for game admins to not want the player on their server in the future; in particular the name containing a slur or other prohibited content that is not expected to be a substring of another word of the server.

@Chief-Engineer
Copy link
Contributor Author

Should the regex username ban have the functionality to auto extend into a full ban? In cases in witch a regex ban is significant enough for game admins to not want the player on their server in the future; in particular the name containing a slur or other prohibited content that is not expected to be a substring of another word of the server.

I think that'd be a nice feature, but I wouldn't say it's required for the initial implementation. Once #25293 is done then this would be an intrinsic capability of all bans.

I'm also going to answer the question you DMed me on discord here to let other people see it and share their opinions if they feel the need to. You asked if these bans should be separate from existing bans or not. PJB is probably going to be who will review the DB changes so it'd be best to ask them but imo it's fine for username bans to be separate with how our current ban system works. Username bans would primarily be to prevent certain usernames from being used, not to prevent specific people from joining, so I feel like having some separation is appropriate just as it is appropriate for role bans and game bans to be separate. I can think of some cases where we may want to combine username bans with account/ip bans, but I suspect those would be extremely rare. Once #25293 is done, I think we'd want usernames to be a ban target so they would to an extent be merged, but #25293 requires a complete DB restructuring anyway so I don't think it'd save any time to consider the changes that will be necessary for #25293 at the moment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Feature Request This issue is a feature request. Priority: 1-Urgent GET ON IT STAT
Projects
Status: 🔖 Defined
Development

Successfully merging a pull request may close this issue.

3 participants