Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin audit logs #19672

Open
8 tasks
Tracked by #23246
Chief-Engineer opened this issue Aug 30, 2023 · 1 comment · May be fixed by #31736
Open
8 tasks
Tracked by #23246

Admin audit logs #19672

Chief-Engineer opened this issue Aug 30, 2023 · 1 comment · May be fixed by #31736
Labels
Issue: Feature Request This issue is a feature request. Priority: 1-Urgent GET ON IT STAT

Comments

@Chief-Engineer
Copy link
Contributor

Chief-Engineer commented Aug 30, 2023

There's currently a system for logging round actions by admins and players, called admin logs. However not all actions make sense to log within a round, so a separate round-independent logging system is needed. The system would log actions taken by admins that are not round dependent, like changing permissions and whitelists, so it'd make sense to call it admin logs, but that name is taken so I'm not sure what to call it.

List of things that should be logged, roughly in order of importance:

  • Ban exemption updates
  • Whitelist/dewhitelist
  • Kicks (maybe better as a round log)
  • Editing notes/bans (currently sort of logged but doesn't include any information about what was changed and doesn't retain a history of editors)
  • Permissions changes, including group permission changes and group membership changes
  • Title changes

Some things that are already logged in some way, and so are very low priority, but would ideally still be either logged or at least accessible from the same system for centralization:

  • (Un)bans, including role bans
  • Creating/deleting notes

Things every log should include, if possible:

  • Who did
  • what,
  • when did they do it,
  • who or what was affected, and
  • how was it affected

Example:
Chief_Engineer modified ban with ID 123 at timestamp. New expiration: timestamp2.

  • Chief_Engineer is the who
  • modified ban is the what
  • timestamp tells you when it was done
  • the ban with ID 123 is what was affected
  • "New expiration: timestamp2" tells you part of how it was affected. Combining this with an earlier log, like the last modification or the ban creation log allows someone to figure out the full effect of the action that led to this log. The interface should have some easy way to get this information, like searching for all logs related to the ban with ID 123.
@Chief-Engineer Chief-Engineer added Priority: 2-Before Release This needs to be fixed before release, but is not an immediate issue Issue: Feature Request This issue is a feature request. labels Aug 30, 2023
@Chief-Engineer Chief-Engineer mentioned this issue Dec 29, 2023
3 tasks
@Chief-Engineer Chief-Engineer changed the title Permission change logs Admin action logs Mar 13, 2024
@ShadowCommander ShadowCommander added Priority: 1-Urgent GET ON IT STAT and removed Priority: 2-Before Release This needs to be fixed before release, but is not an immediate issue labels Mar 19, 2024
@Chief-Engineer Chief-Engineer changed the title Admin action logs Admin audit logs May 23, 2024
@Chief-Engineer
Copy link
Contributor Author

Renamed to audit logs as suggested by Julian

@dffdff2423 dffdff2423 linked a pull request Sep 2, 2024 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Feature Request This issue is a feature request. Priority: 1-Urgent GET ON IT STAT
Projects
Status: 🔖 Defined
Development

Successfully merging a pull request may close this issue.

2 participants