-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NewMed, Implementing Medical Gameplay into SS14 #19383
base: master
Are you sure you want to change the base?
Conversation
@deltanedas This is the updated medical branch, I'm still working on porting the stuff over from the other branch but it's quite a bit simpler and easier to use. Sorry for leaving the old branch sitting for so long, I needed a break from coding for a while since work was getting hectic. It's calmed down alot now so I'm able to work on this more :) |
Pog, someone's doing surgery again |
just a week away |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
This comment was marked as off-topic.
This comment was marked as off-topic.
1 similar comment
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Guys, it will be people. The person may have personal problems. Many people have been waiting for this refactoring for more than a year and are ready to wait a little longer. And if someone can’t stand it, then take it and code it yourself |
submodule was already ok pro |
Yeah, It was a bad merge, some weird shit happened and i thought it was the submodule acting up. I'm going to remove the submodule update so that the tests don't break |
I work full-time as a AAA game developer, I work on SS14 in my spare time (Which has been a bit limited as of late). "Just a week away" is a meme, not a promise and it will get done when it gets done. Medical gameplay is complex and touches many systems, which means it takes time to code (especially if you want to do it properly). |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
requires #20202 |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
358229c
to
4c5e7a0
Compare
Would be cool to have meds that have to be sprayed into the wounds. |
# Conflicts: # Content.Server/Chemistry/ReagentEffects/ChemCleanBloodstream.cs # Content.Server/Chemistry/ReagentEffects/Oxygenate.cs # Content.Server/Magic/MagicSystem.cs
Slowly seeing how all squares get filled :D |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Add estrogen and testosterone |
surgery. just a week away |
please god, provide me peak… |
This comment was marked as off-topic.
This comment was marked as off-topic.
Newmed isn't dead, I just need to refactor parts of chemistry before I can continue. Starting with: #30254 .
|
The mythical medical
refactorsystem. Heard whispered in hushed tones in the corners of the contributor channels, it is indeed REAL! If you listen very carefully you might be able to hear it's cry.... "Just a week away"Requires: #30254, (Chemistry Refactor Pt.2)
Important
Development on this PR is temporarily paused. Development will resume once the chemistry refactor is complete.
Discord discussion thread (for those that prefer discord):
https://discord.com/channels/310555209753690112/1206508273704894525
I will also be posting/discussing design there and I check it more actively than github, so it's a better place to bring up design ideas/questions. You can also use github discussions if you don't like discord, I just don't check it as often. :)
About the PR
This is a complete rewrite of the wounds branch, focusing on making it easier to integrate in forks while being more extensible. I also simplified the logic a bit and added some helper functions for body system.
Progress checklist
TODO: update the progress checklist
Rough Current System Progress as of writing (7/22/24):
Why / Balance
Technical details
Media
Breaking changes
This is going to cause issues with custom damage types and weapon damage or humanoid armor will need to be re-balanced to work properly with wounds. Additionally, any new races will need to be setup with either the common humanoid traumas or require custom traumas to be created. If woundables are not present on a humanoid it will never enter crit or death
Changelog