Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NewMed, Implementing Medical Gameplay into SS14 #19383

Draft
wants to merge 160 commits into
base: master
Choose a base branch
from

Conversation

Jezithyr
Copy link
Contributor

@Jezithyr Jezithyr commented Aug 21, 2023

The mythical medical refactor system. Heard whispered in hushed tones in the corners of the contributor channels, it is indeed REAL! If you listen very carefully you might be able to hear it's cry.... "Just a week away"

Requires: #30254, (Chemistry Refactor Pt.2)

Important

Development on this PR is temporarily paused. Development will resume once the chemistry refactor is complete.

Discord discussion thread (for those that prefer discord):
https://discord.com/channels/310555209753690112/1206508273704894525
I will also be posting/discussing design there and I check it more actively than github, so it's a better place to bring up design ideas/questions. You can also use github discussions if you don't like discord, I just don't check it as often. :)

About the PR

This is a complete rewrite of the wounds branch, focusing on making it easier to integrate in forks while being more extensible. I also simplified the logic a bit and added some helper functions for body system.

Progress checklist

TODO: update the progress checklist

Rough Current System Progress as of writing (7/22/24):

  • WoundSystem: Done
  • WoundingLogic: Done
  • MedicalConditions: 50%
  • BleedingSystem: 80%
  • ConsciousnessSystem: 80%
  • PainSystem: 60%
  • BloodTypes: Done
  • Pulse/Circulation: 60%
  • Breathing: Done
  • EnergySystem(Metabolism): 70%
  • Stomach/Digestion: 20%
  • Eating/Drinking: 30%
  • Liver/Scrubbing/Poision: 0%
  • ReagentAbsorption(Metabolism): 10%
  • Treatments: 20%
  • Surgery(Porting RMC-14 Surgery): 0%
  • MedicalMenu: 10%
  • "QuickTreatment": 0%

Why / Balance

Technical details

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

This is going to cause issues with custom damage types and weapon damage or humanoid armor will need to be re-balanced to work properly with wounds. Additionally, any new races will need to be setup with either the common humanoid traumas or require custom traumas to be created. If woundables are not present on a humanoid it will never enter crit or death

Changelog

@Jezithyr Jezithyr mentioned this pull request Aug 21, 2023
37 tasks
@Jezithyr
Copy link
Contributor Author

@deltanedas This is the updated medical branch, I'm still working on porting the stuff over from the other branch but it's quite a bit simpler and easier to use. Sorry for leaving the old branch sitting for so long, I needed a break from coding for a while since work was getting hectic. It's calmed down alot now so I'm able to work on this more :)
I'll try to keep you up to date in the discussion as I add/rewrite functionality

@VektorZ1
Copy link

Pog, someone's doing surgery again

@UbaserB
Copy link
Contributor

UbaserB commented Aug 21, 2023

just a week away

@github-actions github-actions bot added Merge Conflict This PR currently has conflicts that need to be addressed. and removed Merge Conflict This PR currently has conflicts that need to be addressed. labels Aug 22, 2023
@space-wizards space-wizards deleted a comment from github-actions bot Aug 24, 2023
@github-actions github-actions bot added the Merge Conflict This PR currently has conflicts that need to be addressed. label Aug 30, 2023
@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added Merge Conflict This PR currently has conflicts that need to be addressed. and removed Merge Conflict This PR currently has conflicts that need to be addressed. labels Aug 31, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@nopeingeneer

This comment was marked as off-topic.

1 similar comment
@VektorZ1

This comment was marked as off-topic.

@UbaserB

This comment was marked as off-topic.

@KingOnBudget

This comment was marked as off-topic.

@BolloTea
Copy link

BolloTea commented Sep 14, 2023

Guys, it will be people. The person may have personal problems. Many people have been waiting for this refactoring for more than a year and are ready to wait a little longer. And if someone can’t stand it, then take it and code it yourself

@github-actions github-actions bot removed the Merge Conflict This PR currently has conflicts that need to be addressed. label Sep 14, 2023
@deltanedas
Copy link
Contributor

submodule was already ok pro

@Jezithyr
Copy link
Contributor Author

Jezithyr commented Sep 15, 2023

submodule was already ok pro

Yeah, It was a bad merge, some weird shit happened and i thought it was the submodule acting up. I'm going to remove the submodule update so that the tests don't break

@Jezithyr
Copy link
Contributor Author

Just a week away…

I work full-time as a AAA game developer, I work on SS14 in my spare time (Which has been a bit limited as of late). "Just a week away" is a meme, not a promise and it will get done when it gets done. Medical gameplay is complex and touches many systems, which means it takes time to code (especially if you want to do it properly).

@github-actions github-actions bot added the Merge Conflict This PR currently has conflicts that need to be addressed. label Sep 15, 2023
@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Jezithyr
Copy link
Contributor Author

requires #20202

@github-actions github-actions bot removed the Merge Conflict This PR currently has conflicts that need to be addressed. label Sep 16, 2023
@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added Merge Conflict This PR currently has conflicts that need to be addressed. and removed Merge Conflict This PR currently has conflicts that need to be addressed. labels Sep 16, 2023
@Jezithyr Jezithyr closed this Sep 21, 2023
@Agustron24
Copy link

Would be cool to have meds that have to be sprayed into the wounds.
Like spraying space cleaner on burns for inmideatly increase the pain

# Conflicts:
#	Content.Server/Chemistry/ReagentEffects/ChemCleanBloodstream.cs
#	Content.Server/Chemistry/ReagentEffects/Oxygenate.cs
#	Content.Server/Magic/MagicSystem.cs
@github-actions github-actions bot removed the Merge Conflict This PR currently has conflicts that need to be addressed. label May 14, 2024
@Agustron24
Copy link

Slowly seeing how all squares get filled :D

Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the Merge Conflict This PR currently has conflicts that need to be addressed. label May 24, 2024
@github-actions github-actions bot removed the Merge Conflict This PR currently has conflicts that need to be addressed. label Jun 23, 2024
@github-actions github-actions bot added the Merge Conflict This PR currently has conflicts that need to be addressed. label Jun 30, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@z9ctn4fn
Copy link

Add estrogen and testosterone

@whateverusername0
Copy link
Contributor

surgery. just a week away

@Verbalase
Copy link

please god, provide me peak…

@Brandon-Huu

This comment was marked as off-topic.

@Jezithyr
Copy link
Contributor Author

Newmed isn't dead, I just need to refactor parts of chemistry before I can continue. Starting with: #30254 .

  • Part 1 of the chem refactor is converting Reagents/Reactions to Entities and adding support for creating/removing/modifying reagents/reactions during gameplay. This is something that will be shared/co-developed with RMC-14 (they need the functionality for creating randomized chems).
  • Part 2 of the chem refactor is updating the solutions API to be less complicated/convoluted to use, moving solutions to use fixedpoint4 for more precision, and implementing rate limiting for reactions. Once part 2 is done, work can continue on NewMed since it will be no longer held back by missing chem functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: UI Can be reviewed or fixed by people who are knowledgeable with UI design Holy Shit This is real important!! Merge Conflict This PR currently has conflicts that need to be addressed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet