Chemistry Refactor Pt.1 #30254
Draft
Chemistry Refactor Pt.1 #30254
+7,149
−3,216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Changes: UI
1 task
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
the
Merge Conflict
Jezithyr
removed
the
Merge Conflict
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
github-actions
bot
added
the
Merge Conflict
2 tasks
github-actions
bot
removed
the
Merge Conflict
github-actions
bot
added
the
Merge Conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
Merge Conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
removed
the
Merge Conflict
Jezithyr
removed
the
Changes: UI
github-actions
bot
added
the
Changes: UI
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
1 similar comment
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
Merge Conflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Converts reagent and reaction prototypes into entities and adds the ability to define custom reagents during gameplay. This will allow for the possibility of procedural reagent/reaction generation.
Requires: #31249
Why / Balance
Reagents/Reactions being tied to prototypes limits their definition to YAML and doesn't allow for runtime modification or creation of reagent/reactions. To support runtime creation both prototypes are converted to entities/components which allows them to be created/modified/removed at any point.
Technical details
TODO: outline specifics here
Media
Breaking changes
TODO: API changes
TODO: Steps for migrating
Changelog