feat: add host support for multiexponentiations using precomputed partition method (PROOF-831) #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -35,6 +35,8 @@ namespace sxt::mtxpp2 { | |||
| //-------------------------------------------------------------------------------------------------- | |||
| template <bascrv::element T> | |||
| class in_memory_partition_table_accessor final : public partition_table_accessor<T> { | |||
| static constexpr unsigned num_entries = 1u << 16u; | |||
There was a problem hiding this comment.
There are a number of instances in the code where the number of entries get set to 1u << 16u. Do you think adding a constants component in multiexp/pippenger2 would have any value? I'm not sure if the number of entries supported will ever change or if incorrectly setting the number of entries will be difficult to debug, so it might not be worth it.
| basct::cspan<uint8_t> scalars, unsigned offset) noexcept { | ||
| auto num_products = products.size(); | ||
| auto n = static_cast<unsigned>(scalars.size() * 8u / num_products); | ||
| constexpr auto partition_table_size_v = 1u << 16u; |
There was a problem hiding this comment.
I think you can get rid of this variable.
Comment on lines
69
to
70
| std::vector<E> data((1u << 16u) * 2); | ||
| data[1u << 16u] = 12; |
There was a problem hiding this comment.
Could these be partition_table_size_v?
jacobtrombetta
approved these changes
May 22, 2024
|
🎉 This PR is included in version 1.55.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Support computing multiexponentiations using Pippenger's partition algorithm for the host side. This is the cpu version of #130
What changes are included in this PR?
Are these changes tested?
Yes