Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unused Box linter warning. #1463

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

ttsugriy
Copy link

@ttsugriy ttsugriy commented Sep 4, 2023

cargo check is not happy with original code

    = note: call `drop(Box::from_raw(ptr))` if you intend to drop the `Box`
    = note: `#[warn(unused_must_use)]` on by default
help: use `let _ = ...` to ignore the resulting value
    |
151 |             let _ = Box::from_raw(writing);
    |             +++++++

and adding drop is not only recommended but also makes the intent explicit.

`cargo check` is not happy with original code
```
    = note: call `drop(Box::from_raw(ptr))` if you intend to drop the `Box`
    = note: `#[warn(unused_must_use)]` on by default
help: use `let _ = ...` to ignore the resulting value
    |
151 |             let _ = Box::from_raw(writing);
    |             +++++++
```
and adding `drop` is not only recommended but also makes the intent explicit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant