Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Epic: API Refactoring #1764

Closed
48 of 61 tasks
avive opened this issue Jan 31, 2020 · 17 comments
Closed
48 of 61 tasks

Epic: API Refactoring #1764

avive opened this issue Jan 31, 2020 · 17 comments
Assignees
@lrettig
Projects
Development API

Comments

@avive
Copy link
Contributor

avive commented Jan 31, 2020 •
edited by lrettig

For background on motivation and design, see spacemeshos/SMIPS#21 and https://github.com/spacemeshos/api.

Phases

Phase 1: E2E proof of concept (#2041)

implement and test single Echo endpoint in NodeService (totally independent of existing grpc server)

  • E2E POC test of grpc
  • tests
  • PR

Phase 2: CLI support (#2043)

add CLI flags and allow new NodeService to be switched on

  • Add config/command line support to enable/disable individual services
  • tests
  • PR

Phase 3: grpc-gateway proof of concept (#2053)

implement and test single Echo endpoint in NodeService using grpc-gateway server (totally independent of existing grpc-gateway server)

  • E2E POC test of grpc-gateway
  • tests
  • PR

Phase 4: multiplexing grpc (#2054)

implement a second new GRPC service and multiplex it onto the same server/port as NodeService

  • Multiplex second grpc service on single port/server
  • tests
  • PR

Phase 5: multiplexing grpc-gateway (#2055)

do the same for the grpc-gateway server

  • Add a second grpc gateway endpoint to MeshService (spacemeshos/api@a91231e)
  • Multiplex second grpc gateway service on single port/server
  • tests
  • PR

Phase 6: NodeService (#2056)

fully implement this service, excluding stream endpoints

  • finish NodeService implementation (no streams)
  • tests
  • PR

Phase 7: second grpc service (#2059)

implement a second service, MeshService, and test

  • finish MeshService implementation (no streams)
    • LayersQuery
    • AccountMeshDataQuery
  • tests
  • PR
  • handle TODO items in code

Phase 8: MeshService streams (#2061)

  • finish MeshService streams
    • AccountMeshDataStream
    • LayerStream
  • add stream hooks in production code
  • tests
    • test stream hooks (app test)
  • PR
  • handle TODO items in code

Phase 9: finish implementing grpc services (#2071)

  • GlobalStateService
  • SmesherService
  • TxService
  • tests
  • PR
  • handle TODO items in code

Phase 10: docs (#2083)

document everything!

  • command line flags
  • how to start/stop the grpc services
  • how to start/stop the gateway service
  • how queries work
  • how streams work, the reporter infrastructure (in particular, sending full vs. partial data)
  • error handling: what various endpoints do when given invalid or missing input, or when they find nothing to return, and why these decisions were made, zero max results/huge offsets for queries, why we don't return full internal error messages to API clients
  • desired behavior while syncing/when not fully synced (Behavior while syncing api#100)

Phase 11: cleanup (#2131)

remove/deprecate old API, grpc service, grpc-gateway service, and all protobuf build code. Note: most of this work was already done in #2036 and can be carried over from that branch.

  • Remove old API code (Remove old GRPC API #2078)
  • Remove protobuf scripts
  • Update tests to use new API
  • Remove unused data elements from each of the services (I think this is already done, double-check it)

Phase 12: missing stuff

fill in the endpoints/data elements that weren't previously implemented because of functionality missing in go-spacemesh

Phase 13: optimization

replace naive implementations of data queries with optimized implementations - may require adding DB indices in some cases

Misc
@avive avive added the Epic label Jan 31, 2020
@avive avive added this to the TN2 milestone Jan 31, 2020
@avive avive added this to Backlog in Development via automation Jan 31, 2020
@noamnelke
Copy link
Member

This can be done with no code changes to the node if the SMApp uses the REST endpoints instead of gRPC.

The node currently exposes both a gRPC interface and an HTTP/JSON interface for all endpoints. If the SMApp starts using the HTTP interface, we can use a public API gateway that only exposes a subset of endpoints and redirects requests from those endpoints to a set of backing nodes using round-robin (or similar load balancing mechanism).

I think this makes a better architecture than nodes maintaining a persistent gRPC session with remote, user-controlled wallets.

We're currently in the process of doing the same transition for the same reason for the PoET service: #1716

@avive
Copy link
Contributor Author

avive commented Feb 3, 2020

yes, this makes sense architecturally.

@avive avive added the api label Feb 16, 2020
@avive avive modified the milestones: TN2_GC, TN2 Feb 17, 2020
@avive
Copy link
Contributor Author

avive commented Mar 26, 2020

@ilans - this is what I mentioned in our talk about the API

@avive
Copy link
Contributor Author

avive commented Mar 26, 2020

Consider adding pagination to all methods which return a list of data items. @IlyaVi

@avive
Copy link
Contributor Author

avive commented Apr 6, 2020

I believe we should refactor the API into categories / facades in the node level instead of just having a flat list of methods. This can be as simple as adding the facade name after v1 in methods rest urls. e.g. /v1/mesh/method1...

Additional things to consider:

  1. Adding pub/sub support for server-side streaming data - at least for GRPC over http2. Some GRPC clients support server-side streaming of events. Dashboard, explorer and wallet can use this over GRPC.

  2. Add flags to disable / enable only some API categories/facades - e.g. add a flag not to open node management features via the API while still providing other API categories.

@lrettig

@avive
Copy link
Contributor Author

avive commented Apr 6, 2020

Inventory of API clients:

  1. App / Wallet.
  2. Dashboard backend.
  3. Explorer backend.
  4. Backup agent (backup testnet data in a restorable way).
  5. Marketing programs reports. e.g. rewards program top 100.

@avive
Copy link
Contributor Author

avive commented Apr 6, 2020

@lrettig @YaronWittenstein - We need to specify the API category for smart wallets. e.g. A method to read data from an app instance.

@lrettig
Copy link
Member

lrettig commented Apr 6, 2020

Adding pub/sub support for server-side streaming data - at least for GRPC over http2. Some GRPC clients support server-side streaming of events. Dashboard, explorer and wallet can use this over GRPC.

I wasn't aware that you can do streaming over GRPC. That's exciting to hear. I'll look into it. I think streaming is important but I'm not married to websockets.

Add flags to disable / enable only some API categories/facades - e.g. add a flag not to open node management features via the API while still providing other API categories.

Agree. For comparison, this is how geth works:

--rpcapi API's offered over the HTTP-RPC interface (default: eth,net,web3)
--wsapi API's offered over the WS-RPC interface (default: eth,net,web3)
--ipcapi API's offered over the IPC-RPC interface (default: admin,debug,eth,miner,net,personal,shh,txpool,web3)

@lrettig lrettig added the data label Apr 6, 2020
@lrettig
Copy link
Member

lrettig commented Apr 6, 2020

@lrettig @YaronWittenstein - We need to specify the API category for smart wallets. e.g. A method to read data from an app instance.

I don't think the smart wallet, or any dapp, needs to use a special API. It's just transactions, right? Or in the case of statically reading data, it's like a "quasi" transaction. Basically we need to start thinking about what a Spacemesh web3.js would look like.

@YaronWittenstein
Copy link

YaronWittenstein commented Apr 6, 2020 •
edited

@lrettig @YaronWittenstein - We need to specify the API category for smart wallets. e.g. A method to read data from an app instance.

I don't think the smart wallet, or any dapp, needs to use a special API. It's just transactions, right? Or in the case of statically reading data, it's like a "quasi" transaction. Basically we need to start thinking about what a Spacemesh web3.js would look like.

I'll soon start working on App's Storage ABI.
The consequent tasks should be exposing gRPC / HTTP interface over the Full-Node.
(which will propagate requests to the upcoming go-svm client)

@avive
Copy link
Contributor Author

avive commented Apr 13, 2020

@lrettig @YaronWittenstein - We need to specify the API category for smart wallets. e.g. A method to read data from an app instance.

I don't think the smart wallet, or any dapp, needs to use a special API. It's just transactions, right? Or in the case of statically reading data, it's like a "quasi" transaction. Basically we need to start thinking about what a Spacemesh web3.js would look like.

yes - this epic is what is the sm.js looks like...

regarding smart wallet - the part in the api which is not txs that we need to specify is the method(s) to read wallet storage data. For example, to populate a smart wallet ui in the app...

@lrettig
Copy link
Member

lrettig commented Apr 13, 2020

From Discord:

For now i see that mem pool overflow affect some GRPC requests. v1/accounttxs for example, because mem pool > than 4 MB

image

@lrettig lrettig added this to To do in API Apr 13, 2020
@lrettig
Copy link
Member

lrettig commented Apr 13, 2020

regarding smart wallet - the part in the api which is not txs that we need to specify is the method(s) to read wallet storage data. For example, to populate a smart wallet ui in the app...

You just write a "constant" method in the smart contract and call it like this:

https://web3js.readthedocs.io/en/v1.2.6/web3-eth-contract.html#methods-mymethod-call

@avive
Copy link
Contributor Author

avive commented Apr 13, 2020

I don't think this is yaron's current design for read-only data in svm... I think he wants to have an explicit api for this use case... @YaronWittenstein

@YaronWittenstein
Copy link

YaronWittenstein commented Apr 13, 2020 •
edited

@avive @lrettig

The current App Storage infrastructure has no notion of permissions.
My plan was to add such constraints on top - when we'll get to implementing the SMESH language.

@lrettig
Copy link
Member

lrettig commented Apr 14, 2020

Agree with Yaron. You can't have permissions on state data. Every node needs to be able to read all of the state to validate transactions - unless you want to talk about doing something super complicated using zero knowledge proofs, and we're obviously not going that route anytime soon!

Can totally add that on top using encryption of course :)

@lrettig lrettig moved this from To do to In progress in API Jun 4, 2020
This was referenced Jun 10, 2020
Closed
Open
@lrettig lrettig changed the title API Refactoring (WIP) Epic: API Refactoring Jun 12, 2020
@lrettig lrettig mentioned this issue Jun 12, 2020
Closed
3 tasks
@lrettig lrettig mentioned this issue Jul 2, 2020
Closed
@lrettig lrettig mentioned this issue Jul 14, 2020
Closed
bors bot pushed a commit that referenced this issue Jul 16, 2020
@lrettig
API phase 3: grpc-gateway proof of concept (#2053)
637cf87 
## Motivation
See #1764

## Changes
- adds a new GRPC gateway json-http service
- adds related flags and configs (for now, there is only a single flag to enable it, and another flag to set the port; it will be enabled for all corresponding new GRPC services that are also enabled)
- starts/stops it in app setup/teardown

## Test Plan
- tests new commandline flags (turning on the service, setting the port)
- tests enabling the service in combination with enabling new GRPC service (at least one is required)
- tests communication between new JSON service and new GRPC service
- E2E test of one JSON service endpoint
bors bot pushed a commit that referenced this issue Jul 16, 2020
@lrettig
API phase 3: grpc-gateway proof of concept (#2053)
f9ba7ca 
## Motivation
See #1764

## Changes
- adds a new GRPC gateway json-http service
- adds related flags and configs (for now, there is only a single flag to enable it, and another flag to set the port; it will be enabled for all corresponding new GRPC services that are also enabled)
- starts/stops it in app setup/teardown

## Test Plan
- tests new commandline flags (turning on the service, setting the port)
- tests enabling the service in combination with enabling new GRPC service (at least one is required)
- tests communication between new JSON service and new GRPC service
- E2E test of one JSON service endpoint
bors bot pushed a commit that referenced this issue Jul 16, 2020
@lrettig
API phase 3: grpc-gateway proof of concept (#2053)
5382f02 
## Motivation
See #1764

## Changes
- adds a new GRPC gateway json-http service
- adds related flags and configs (for now, there is only a single flag to enable it, and another flag to set the port; it will be enabled for all corresponding new GRPC services that are also enabled)
- starts/stops it in app setup/teardown

## Test Plan
- tests new commandline flags (turning on the service, setting the port)
- tests enabling the service in combination with enabling new GRPC service (at least one is required)
- tests communication between new JSON service and new GRPC service
- E2E test of one JSON service endpoint
bors bot pushed a commit that referenced this issue Jul 17, 2020
@lrettig
API phase 3: grpc-gateway proof of concept (#2053)
bc6bceb 
## Motivation
See #1764

## Changes
- adds a new GRPC gateway json-http service
- adds related flags and configs (for now, there is only a single flag to enable it, and another flag to set the port; it will be enabled for all corresponding new GRPC services that are also enabled)
- starts/stops it in app setup/teardown

## Test Plan
- tests new commandline flags (turning on the service, setting the port)
- tests enabling the service in combination with enabling new GRPC service (at least one is required)
- tests communication between new JSON service and new GRPC service
- E2E test of one JSON service endpoint
bors bot pushed a commit that referenced this issue Jul 17, 2020
@lrettig
API phase 3: grpc-gateway proof of concept (#2053)
462e925 
## Motivation
See #1764

## Changes
- adds a new GRPC gateway json-http service
- adds related flags and configs (for now, there is only a single flag to enable it, and another flag to set the port; it will be enabled for all corresponding new GRPC services that are also enabled)
- starts/stops it in app setup/teardown

## Test Plan
- tests new commandline flags (turning on the service, setting the port)
- tests enabling the service in combination with enabling new GRPC service (at least one is required)
- tests communication between new JSON service and new GRPC service
- E2E test of one JSON service endpoint
bors bot pushed a commit that referenced this issue Jul 17, 2020
@lrettig
API phase 3: grpc-gateway proof of concept (#2053)
109d526 
## Motivation
See #1764

## Changes
- adds a new GRPC gateway json-http service
- adds related flags and configs (for now, there is only a single flag to enable it, and another flag to set the port; it will be enabled for all corresponding new GRPC services that are also enabled)
- starts/stops it in app setup/teardown

## Test Plan
- tests new commandline flags (turning on the service, setting the port)
- tests enabling the service in combination with enabling new GRPC service (at least one is required)
- tests communication between new JSON service and new GRPC service
- E2E test of one JSON service endpoint
bors bot pushed a commit that referenced this issue Jul 18, 2020
@lrettig
API phase 3: grpc-gateway proof of concept (#2053)
cc25897 
## Motivation
See #1764

## Changes
- adds a new GRPC gateway json-http service
- adds related flags and configs (for now, there is only a single flag to enable it, and another flag to set the port; it will be enabled for all corresponding new GRPC services that are also enabled)
- starts/stops it in app setup/teardown

## Test Plan
- tests new commandline flags (turning on the service, setting the port)
- tests enabling the service in combination with enabling new GRPC service (at least one is required)
- tests communication between new JSON service and new GRPC service
- E2E test of one JSON service endpoint
bors bot pushed a commit that referenced this issue Jul 18, 2020
@lrettig
API phase 3: grpc-gateway proof of concept (#2053)
044c8f1 
## Motivation
See #1764

## Changes
- adds a new GRPC gateway json-http service
- adds related flags and configs (for now, there is only a single flag to enable it, and another flag to set the port; it will be enabled for all corresponding new GRPC services that are also enabled)
- starts/stops it in app setup/teardown

## Test Plan
- tests new commandline flags (turning on the service, setting the port)
- tests enabling the service in combination with enabling new GRPC service (at least one is required)
- tests communication between new JSON service and new GRPC service
- E2E test of one JSON service endpoint
bors bot pushed a commit that referenced this issue Jul 19, 2020
@lrettig
API phase 3: grpc-gateway proof of concept (#2053)
1eca8c8 
## Motivation
See #1764

## Changes
- adds a new GRPC gateway json-http service
- adds related flags and configs (for now, there is only a single flag to enable it, and another flag to set the port; it will be enabled for all corresponding new GRPC services that are also enabled)
- starts/stops it in app setup/teardown

## Test Plan
- tests new commandline flags (turning on the service, setting the port)
- tests enabling the service in combination with enabling new GRPC service (at least one is required)
- tests communication between new JSON service and new GRPC service
- E2E test of one JSON service endpoint
bors bot pushed a commit that referenced this issue Jul 20, 2020
@lrettig
API phase 3: grpc-gateway proof of concept (#2053)
28bf567 
## Motivation
See #1764

## Changes
- adds a new GRPC gateway json-http service
- adds related flags and configs (for now, there is only a single flag to enable it, and another flag to set the port; it will be enabled for all corresponding new GRPC services that are also enabled)
- starts/stops it in app setup/teardown

## Test Plan
- tests new commandline flags (turning on the service, setting the port)
- tests enabling the service in combination with enabling new GRPC service (at least one is required)
- tests communication between new JSON service and new GRPC service
- E2E test of one JSON service endpoint
bors bot pushed a commit that referenced this issue Jul 20, 2020
@lrettig
API phase 3: grpc-gateway proof of concept (#2053)
5658d9c 
## Motivation
See #1764

## Changes
- adds a new GRPC gateway json-http service
- adds related flags and configs (for now, there is only a single flag to enable it, and another flag to set the port; it will be enabled for all corresponding new GRPC services that are also enabled)
- starts/stops it in app setup/teardown

## Test Plan
- tests new commandline flags (turning on the service, setting the port)
- tests enabling the service in combination with enabling new GRPC service (at least one is required)
- tests communication between new JSON service and new GRPC service
- E2E test of one JSON service endpoint
bors bot pushed a commit that referenced this issue Jul 20, 2020
@lrettig
API phase 3: grpc-gateway proof of concept (#2053)
e035211 
## Motivation
See #1764

## Changes
- adds a new GRPC gateway json-http service
- adds related flags and configs (for now, there is only a single flag to enable it, and another flag to set the port; it will be enabled for all corresponding new GRPC services that are also enabled)
- starts/stops it in app setup/teardown

## Test Plan
- tests new commandline flags (turning on the service, setting the port)
- tests enabling the service in combination with enabling new GRPC service (at least one is required)
- tests communication between new JSON service and new GRPC service
- E2E test of one JSON service endpoint
bors bot pushed a commit that referenced this issue Jul 22, 2020
@lrettig
API phase 6: Finish NodeService (#2056)
f9e2f45 
## Motivation
See #1764

## Changes
- Implements each previously unimplemented NodeService endpoint

## Test Plan
- Adds tests for every implemented endpoint in NodeService
- These are implemented as an array of test data and subtests
This was referenced Jul 27, 2020
Closed
Closed
@lrettig lrettig mentioned this issue Aug 29, 2020
Closed
16 tasks
bors bot pushed a commit that referenced this issue Sep 10, 2020
@lrettig
API phase 9: finish implementing grpc services (#2071)
ce9d5da 
## Motivation
See #1764 
Also Fixes #2116 
Requires #2092, merge that first

## Changes
- Adds stubs for all remaining services and endpoints
- Upgrades to latest API build, renames a few API data items to be consistent with improved naming in the API code
- Allows MeshService to read and return layer root hash: makes TransactionProcessor GetLayerStateRoot method public
- Adds a config param (internal, only for testing) to force the syncer to always enable listening to gossip
- Event Reporter no longer reports any details about Status updates, it just "pings" the listener which is responsible for re-fetching all status items they care about
- Adds account, reward, receipt channels to Reporter; allows Reporter to block, or to increase channel buffer sizes, on initialization
- Allows Reporter report methods to block (useful for tests)
- Implements all endpoints that can be implemented (some, e.g. those involving transaction receipt, cannot yet be implemented)
- Adds a method `GetSmesherID` to ATX to allow the nodeID that created it to be read, as part of finding ATXs by smesher for the API

## Test Plan
- Adds tests for all new endpoints and services
bors bot pushed a commit that referenced this issue Nov 18, 2020
@lrettig
API phase 11: cleanup old API and protoc code (#2131)
7e7ab8d 
## Motivation
See #1764 
Closes #2077, Closes #2078, Closes #2153, Closes #411, Closes #2163, Closes #2145, Closes #2168

## Changes
- Removes old GRPC API and HTTP-JSON gateway code
- Removes protobuf code
- Updates tests to use new API
- Lots of cleanup of the system tests

## Test Plan
No new tests required, this does not add any new functionality. Affected tests are updated/removed.

## TODO
- [x] Remove old API code
- [x] Update tests to use new API instead
- [x] Remove all protobuf-related code and references
- [x] Update README
- [x] Update to API v1.0.0, adding GatewayService to new API for poet (#2133)
- [x] Implement GatewayService (#2156)
- [x] Update poet (spacemeshos/poet#98)
- [x] Fix p2p tests broadcast issue
- [x] Update hardcoded go-spacemesh docker images in configs
- [x] Open issue to replace all `curl`/json http gateway server API interactions in tests with python grpc library (#2185)
- [x] Update system tests (including tx_generator WalletAPI, test_p2p) to use new API
- [x] Make sure spacecraft has been updated to factor in new ports and commandline flags (spacemeshos/spacecraft#1)
- [x] Update hardcoded poet docker image spacemeshos/poet:develop, fix in configs (needs spacemeshos/poet#105)
- [x] Merge #2157 
- [x] Merge #2159
- [x] Merge #2169
bors bot pushed a commit that referenced this issue Nov 18, 2020
@lrettig
API phase 11: cleanup old API and protoc code (#2131)
53ca365 
## Motivation
See #1764 
Closes #2077, Closes #2078, Closes #2153, Closes #411, Closes #2163, Closes #2145, Closes #2168

## Changes
- Removes old GRPC API and HTTP-JSON gateway code
- Removes protobuf code
- Updates tests to use new API
- Lots of cleanup of the system tests

## Test Plan
No new tests required, this does not add any new functionality. Affected tests are updated/removed.

## TODO
- [x] Remove old API code
- [x] Update tests to use new API instead
- [x] Remove all protobuf-related code and references
- [x] Update README
- [x] Update to API v1.0.0, adding GatewayService to new API for poet (#2133)
- [x] Implement GatewayService (#2156)
- [x] Update poet (spacemeshos/poet#98)
- [x] Fix p2p tests broadcast issue
- [x] Update hardcoded go-spacemesh docker images in configs
- [x] Open issue to replace all `curl`/json http gateway server API interactions in tests with python grpc library (#2185)
- [x] Update system tests (including tx_generator WalletAPI, test_p2p) to use new API
- [x] Make sure spacecraft has been updated to factor in new ports and commandline flags (spacemeshos/spacecraft#1)
- [x] Update hardcoded poet docker image spacemeshos/poet:develop, fix in configs (needs spacemeshos/poet#105)
- [x] Merge #2157 
- [x] Merge #2159
- [x] Merge #2169
bors bot pushed a commit that referenced this issue Nov 19, 2020
@lrettig
API phase 11: cleanup old API and protoc code (#2131)
f790a44 
## Motivation
See #1764 
Closes #2077, Closes #2078, Closes #2153, Closes #411, Closes #2163, Closes #2145, Closes #2168

## Changes
- Removes old GRPC API and HTTP-JSON gateway code
- Removes protobuf code
- Updates tests to use new API
- Lots of cleanup of the system tests

## Test Plan
No new tests required, this does not add any new functionality. Affected tests are updated/removed.

## TODO
- [x] Remove old API code
- [x] Update tests to use new API instead
- [x] Remove all protobuf-related code and references
- [x] Update README
- [x] Update to API v1.0.0, adding GatewayService to new API for poet (#2133)
- [x] Implement GatewayService (#2156)
- [x] Update poet (spacemeshos/poet#98)
- [x] Fix p2p tests broadcast issue
- [x] Update hardcoded go-spacemesh docker images in configs
- [x] Open issue to replace all `curl`/json http gateway server API interactions in tests with python grpc library (#2185)
- [x] Update system tests (including tx_generator WalletAPI, test_p2p) to use new API
- [x] Make sure spacecraft has been updated to factor in new ports and commandline flags (spacemeshos/spacecraft#1)
- [x] Update hardcoded poet docker image spacemeshos/poet:develop, fix in configs (needs spacemeshos/poet#105)
- [x] Merge #2157 
- [x] Merge #2159
- [x] Merge #2169
lrettig added a commit that referenced this issue Feb 3, 2021
@lrettig
API phase 11: cleanup old API and protoc code (#2131)
5fa7f41 
See #1764
Closes #2077, Closes #2078, Closes #2153, Closes #411, Closes #2163,
Closes #2145, Closes #2168

- Removes old GRPC API and HTTP-JSON gateway code
- Removes protobuf code
- Updates tests to use new API
- Lots of cleanup of the system tests

No new tests required, this does not add any new functionality. Affected
tests are updated/removed.

- [x] Remove old API code
- [x] Update tests to use new API instead
- [x] Remove all protobuf-related code and references
- [x] Update README
- [x] Update to API v1.0.0, adding GatewayService to new API for poet
  (#2133)
  - [x] Implement GatewayService (#2156)
  - [x] Update poet (spacemeshos/poet#98)
  - [x] Fix p2p tests broadcast issue
  - [x] Update hardcoded go-spacemesh docker images in configs
  - [x] Open issue to replace all `curl`/json http gateway server API
    interactions in tests with python grpc library (#2185)
    - [x] Update system tests (including tx_generator WalletAPI,
      test_p2p) to use new API
      - [x] Make sure spacecraft has been updated to factor in new ports
        and commandline flags
        (spacemeshos/spacecraft#1)
        - [x] Update hardcoded poet docker image
          spacemeshos/poet:develop, fix in configs (needs
          spacemeshos/poet#105)
          - [x] Merge #2157
          - [x] Merge #2159
          - [x] Merge #2169

Cherry-pick, and resolve some merge conflicts
@moshababo moshababo mentioned this issue Mar 2, 2021
Closed
lrettig added a commit that referenced this issue Mar 20, 2021
@lrettig
Testnet version of API Phase 11
6b8a6a5 
Includes #2131 but also some testnet-specific fixes, and restores the
old API

API phase 11: cleanup old API and protoc code (#2131)

See #1764
Closes #2077, Closes #2078, Closes #2153, Closes #411, Closes #2163,
Closes #2145, Closes #2168

- Removes old GRPC API and HTTP-JSON gateway code
- Removes protobuf code
- Updates tests to use new API
- Lots of cleanup of the system tests

No new tests required, this does not add any new functionality. Affected
tests are updated/removed.

- [x] Remove old API code
- [x] Update tests to use new API instead
- [x] Remove all protobuf-related code and references
- [x] Update README
- [x] Update to API v1.0.0, adding GatewayService to new API for poet
  (#2133)
  - [x] Implement GatewayService (#2156)
  - [x] Update poet (spacemeshos/poet#98)
  - [x] Fix p2p tests broadcast issue
  - [x] Update hardcoded go-spacemesh docker images in configs
  - [x] Open issue to replace all `curl`/json http gateway server API
    interactions in tests with python grpc library (#2185)
    - [x] Update system tests (including tx_generator WalletAPI,
      test_p2p) to use new API
      - [x] Make sure spacecraft has been updated to factor in new ports
        and commandline flags
        (spacemeshos/spacecraft#1)
        - [x] Update hardcoded poet docker image
          spacemeshos/poet:develop, fix in configs (needs
          spacemeshos/poet#105)
          - [x] Merge #2157
          - [x] Merge #2159
          - [x] Merge #2169

Cherry-pick, and resolve some merge conflicts

Restore old API
@lrettig lrettig mentioned this issue Mar 22, 2021
Closed
6 tasks
@moshababo moshababo removed this from the TN2 milestone Jun 30, 2021
@lrettig
Copy link
Member

lrettig commented Sep 28, 2021

Everything is done except some documentation and some optimization. There are issues to track all of these and we'll follow up on them separately.

@lrettig lrettig closed this as completed Sep 28, 2021
Development automation moved this from In Progresh to Done Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lrettig lrettig

Labels
None yet
Projects
No open projects
API
  
In progress
Development
  
Done
Milestone
No milestone
Development

No branches or pull requests
5 participants
@avive @YaronWittenstein @noamnelke @lrettig @moshababo