Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to new API #98

Closed
lrettig opened this issue Jun 16, 2020 · 1 comment · Fixed by #105
Closed

Update to new API #98

lrettig opened this issue Jun 16, 2020 · 1 comment · Fixed by #105
Assignees
@lrettig

Comments

@lrettig
Copy link
Member

lrettig commented Jun 16, 2020 •
edited
Loading

Upgrade the poet server broadcaster to use the new API. A new service was added to the API for the poet in spacemeshos/api#118 and implemented in spacemeshos/go-spacemesh#2159.
@lrettig lrettig self-assigned this Jun 16, 2020
@avive avive mentioned this issue Jun 16, 2020
Closed
61 tasks
@lrettig
Copy link
Member Author

lrettig commented Oct 2, 2020

We need this sooner rather than later since we cannot finish updating the system tests, which rely on poet, until this is in place. See spacemeshos/go-spacemesh#2131.

@lrettig lrettig mentioned this issue Oct 2, 2020
Closed
16 tasks
@lrettig lrettig mentioned this issue Oct 13, 2020
Merged
bors bot pushed a commit to spacemeshos/go-spacemesh that referenced this issue Nov 18, 2020
@lrettig
API phase 11: cleanup old API and protoc code (#2131)
7e7ab8d 
## Motivation
See #1764 
Closes #2077, Closes #2078, Closes #2153, Closes #411, Closes #2163, Closes #2145, Closes #2168

## Changes
- Removes old GRPC API and HTTP-JSON gateway code
- Removes protobuf code
- Updates tests to use new API
- Lots of cleanup of the system tests

## Test Plan
No new tests required, this does not add any new functionality. Affected tests are updated/removed.

## TODO
- [x] Remove old API code
- [x] Update tests to use new API instead
- [x] Remove all protobuf-related code and references
- [x] Update README
- [x] Update to API v1.0.0, adding GatewayService to new API for poet (#2133)
- [x] Implement GatewayService (#2156)
- [x] Update poet (spacemeshos/poet#98)
- [x] Fix p2p tests broadcast issue
- [x] Update hardcoded go-spacemesh docker images in configs
- [x] Open issue to replace all `curl`/json http gateway server API interactions in tests with python grpc library (#2185)
- [x] Update system tests (including tx_generator WalletAPI, test_p2p) to use new API
- [x] Make sure spacecraft has been updated to factor in new ports and commandline flags (spacemeshos/spacecraft#1)
- [x] Update hardcoded poet docker image spacemeshos/poet:develop, fix in configs (needs spacemeshos/poet#105)
- [x] Merge #2157 
- [x] Merge #2159
- [x] Merge #2169
bors bot pushed a commit to spacemeshos/go-spacemesh that referenced this issue Nov 18, 2020
@lrettig
API phase 11: cleanup old API and protoc code (#2131)
53ca365 
## Motivation
See #1764 
Closes #2077, Closes #2078, Closes #2153, Closes #411, Closes #2163, Closes #2145, Closes #2168

## Changes
- Removes old GRPC API and HTTP-JSON gateway code
- Removes protobuf code
- Updates tests to use new API
- Lots of cleanup of the system tests

## Test Plan
No new tests required, this does not add any new functionality. Affected tests are updated/removed.

## TODO
- [x] Remove old API code
- [x] Update tests to use new API instead
- [x] Remove all protobuf-related code and references
- [x] Update README
- [x] Update to API v1.0.0, adding GatewayService to new API for poet (#2133)
- [x] Implement GatewayService (#2156)
- [x] Update poet (spacemeshos/poet#98)
- [x] Fix p2p tests broadcast issue
- [x] Update hardcoded go-spacemesh docker images in configs
- [x] Open issue to replace all `curl`/json http gateway server API interactions in tests with python grpc library (#2185)
- [x] Update system tests (including tx_generator WalletAPI, test_p2p) to use new API
- [x] Make sure spacecraft has been updated to factor in new ports and commandline flags (spacemeshos/spacecraft#1)
- [x] Update hardcoded poet docker image spacemeshos/poet:develop, fix in configs (needs spacemeshos/poet#105)
- [x] Merge #2157 
- [x] Merge #2159
- [x] Merge #2169
bors bot pushed a commit to spacemeshos/go-spacemesh that referenced this issue Nov 19, 2020
@lrettig
API phase 11: cleanup old API and protoc code (#2131)
f790a44 
## Motivation
See #1764 
Closes #2077, Closes #2078, Closes #2153, Closes #411, Closes #2163, Closes #2145, Closes #2168

## Changes
- Removes old GRPC API and HTTP-JSON gateway code
- Removes protobuf code
- Updates tests to use new API
- Lots of cleanup of the system tests

## Test Plan
No new tests required, this does not add any new functionality. Affected tests are updated/removed.

## TODO
- [x] Remove old API code
- [x] Update tests to use new API instead
- [x] Remove all protobuf-related code and references
- [x] Update README
- [x] Update to API v1.0.0, adding GatewayService to new API for poet (#2133)
- [x] Implement GatewayService (#2156)
- [x] Update poet (spacemeshos/poet#98)
- [x] Fix p2p tests broadcast issue
- [x] Update hardcoded go-spacemesh docker images in configs
- [x] Open issue to replace all `curl`/json http gateway server API interactions in tests with python grpc library (#2185)
- [x] Update system tests (including tx_generator WalletAPI, test_p2p) to use new API
- [x] Make sure spacecraft has been updated to factor in new ports and commandline flags (spacemeshos/spacecraft#1)
- [x] Update hardcoded poet docker image spacemeshos/poet:develop, fix in configs (needs spacemeshos/poet#105)
- [x] Merge #2157 
- [x] Merge #2159
- [x] Merge #2169
lrettig added a commit to spacemeshos/go-spacemesh that referenced this issue Feb 3, 2021
@lrettig
API phase 11: cleanup old API and protoc code (#2131)
5fa7f41 
See #1764
Closes #2077, Closes #2078, Closes #2153, Closes #411, Closes #2163,
Closes #2145, Closes #2168

- Removes old GRPC API and HTTP-JSON gateway code
- Removes protobuf code
- Updates tests to use new API
- Lots of cleanup of the system tests

No new tests required, this does not add any new functionality. Affected
tests are updated/removed.

- [x] Remove old API code
- [x] Update tests to use new API instead
- [x] Remove all protobuf-related code and references
- [x] Update README
- [x] Update to API v1.0.0, adding GatewayService to new API for poet
  (#2133)
  - [x] Implement GatewayService (#2156)
  - [x] Update poet (spacemeshos/poet#98)
  - [x] Fix p2p tests broadcast issue
  - [x] Update hardcoded go-spacemesh docker images in configs
  - [x] Open issue to replace all `curl`/json http gateway server API
    interactions in tests with python grpc library (#2185)
    - [x] Update system tests (including tx_generator WalletAPI,
      test_p2p) to use new API
      - [x] Make sure spacecraft has been updated to factor in new ports
        and commandline flags
        (spacemeshos/spacecraft#1)
        - [x] Update hardcoded poet docker image
          spacemeshos/poet:develop, fix in configs (needs
          spacemeshos/poet#105)
          - [x] Merge #2157
          - [x] Merge #2159
          - [x] Merge #2169

Cherry-pick, and resolve some merge conflicts
lrettig added a commit to spacemeshos/go-spacemesh that referenced this issue Mar 20, 2021
@lrettig
Testnet version of API Phase 11
6b8a6a5 
Includes #2131 but also some testnet-specific fixes, and restores the
old API

API phase 11: cleanup old API and protoc code (#2131)

See #1764
Closes #2077, Closes #2078, Closes #2153, Closes #411, Closes #2163,
Closes #2145, Closes #2168

- Removes old GRPC API and HTTP-JSON gateway code
- Removes protobuf code
- Updates tests to use new API
- Lots of cleanup of the system tests

No new tests required, this does not add any new functionality. Affected
tests are updated/removed.

- [x] Remove old API code
- [x] Update tests to use new API instead
- [x] Remove all protobuf-related code and references
- [x] Update README
- [x] Update to API v1.0.0, adding GatewayService to new API for poet
  (#2133)
  - [x] Implement GatewayService (#2156)
  - [x] Update poet (spacemeshos/poet#98)
  - [x] Fix p2p tests broadcast issue
  - [x] Update hardcoded go-spacemesh docker images in configs
  - [x] Open issue to replace all `curl`/json http gateway server API
    interactions in tests with python grpc library (#2185)
    - [x] Update system tests (including tx_generator WalletAPI,
      test_p2p) to use new API
      - [x] Make sure spacecraft has been updated to factor in new ports
        and commandline flags
        (spacemeshos/spacecraft#1)
        - [x] Update hardcoded poet docker image
          spacemeshos/poet:develop, fix in configs (needs
          spacemeshos/poet#105)
          - [x] Merge #2157
          - [x] Merge #2159
          - [x] Merge #2169

Cherry-pick, and resolve some merge conflicts

Restore old API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lrettig lrettig

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade broadcaster to use new API spacemeshos/poet
1 participant
@lrettig