Tweak tortoise vote calculation for testnet #2337
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors try |
tryBuild failed: |
lrettig
changed the title
Fix merge conflicts, make lint happy Add context, improve debugging of syncer Context, logging for block listener, syncer Add context to hare outgoing messages Linter More lint and test fixes Fix merge conflicts Pass context down to msg send on net Improve net debug Improve context and logging for outgoing messages Improve context and logging for atx and block flow Remove explicit context and reqID from ReportValidation, and read from message context instead Resolves merge conflicts from testnet-126 branch changes Logging Minor cleanup of atx logging Bugfixes Add log context to fetch request Whitespace
Vote for whole layer if hare results missing Lower tortoise thresholds for testnet Increase verbosity Vote for zero pattern instead Update test to match modified logic Improve log output Stick with old newly good threshold Minor test cleanup Make test more readable Update threshold and test Update votes, test passes Update second test to match new thresholds Cleanup threshold param Cleanup test Gofmt
## Motivation It's confusing whether to click or not to click on the DevOps notes points. Re phrased them to make it clear. Co-authored-by: Lane Rettig <lanerettig@gmail.com> Co-authored-by: Anton Lerner <anton.lerner@gmail.com>
<!-- Please mention the issue fixed by this PR or detailed motivation --> Closes #2068 <!-- `Closes #XXXX, closes #XXXX, ...` links mentioned issues to this PR and automatically closes them when this it's merged --> <!-- Please describe in detail the changes made --> 1. Added `SmesherID` and `Coinbase` fields to `struct Reward` for efficient look-up. Used this to complete the `AccountDataQuery` and `AccountDataStream` endpoints in the API code. 2. Changed the database index for storing Rewards to a key of the form `reward_<coinbase>_<smesherID>_<layerID>` because multiple SmesherIDs could be associated with the same Coinbase. Added a secondary key for Rewards lookups by SmesherID. 3. Changed the `accumulateRewards` function in `mesh/mesh.go` so to support handling multiple smesherIDs associated with a single Coinbase. Moved event reporting of the Rewards from the processor to the mesh code. 4. Added tests to `mesh/meshdb_test.go` to test changes made. 5. Implemented the API endpoints for `SmesherRewardStream` and `SmesherDataQuery` using the endpoints created. 6. Since we now have that there can be multiple `SmesherID`s associated with a particular `Coinbase`, changed the way the rewards are calculated. Now the `blockTotalReward` and `blockLayerReward` are multiplied by the number of blocks produced by a particular `Coinbase`-`SmesherID` pair. <!-- Please specify how these changes were tested (e.g. unit tests, manual testing, etc.) --> Wrote multiple unit tests for both the APIs that I implemented, and the meshdb code that I changed. <!-- This section should be removed when all items are complete --> - [ ] Explain motivation or link existing issue(s) - [ ] Test changes and document test plan - [ ] Update documentation as needed Co-authored-by: Lane Rettig <lanerettig@gmail.com>
## Motivation <!-- Please mention the issue fixed by this PR or detailed motivation --> Closes #2253 <!-- `Closes #XXXX, closes #XXXX, ...` links mentioned issues to this PR and automatically closes them when this it's merged --> ## Changes <!-- Please describe in detail the changes made --> - Fix fatal error in `multi_node_sim` ## Test Plan <!-- Please specify how these changes were tested (e.g. unit tests, manual testing, etc.) --> 1. Attempt to reproduce #2253 following steps from the PR description 2. There should be no fatal error
Remove a lingering reference to gitter from README Co-authored-by: Anton Lerner <anton.lerner@gmail.com>
## Motivation "CI status" for the develop branch is not really well-defined since we don't actually run any CI tasks on the develop branch. Bors runs them on staging, then merges to develop. If we set the status badge to develop, as it is now, it shows "no status." If we set it to staging, it'll show the status of the last bors run, which may have failed (and not been merged), which is misleading. @noamnelke you were right, I concede :)
## Motivation Closes #2225 (obsoletes #2231) ## Changes Remove `Timestamp` field from the `BlockHeader` struct. ## Test Plan Unit tests have been updated and all pass consistently. System tests should be unaffected and will be run. ## DevOps Notes - [x] Does this code require configuration changes? ❌ - [x] Does this code affect public APIs? ❌ - [x] Does this code assume a new version of external services (PoET, elasticsearch, etc.) ❌ - [x] Does this code make changes to log messages that our monitoring infrastructure may rely on? ❌ Co-authored-by: Noam Nelke <noamnelke@gmail.com> Co-authored-by: Lane Rettig <lanerettig@gmail.com>
## Motivation Fixes #2348 ## Changes - replace `t.FailNow()` in non-test goroutine with Panic ## Test Plan N/A ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [ ] Update documentation as needed ## DevOps Notes <!-- Please uncheck these items as applicable to make DevOps aware of changes that may affect releases --> - [x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources) - [x] This PR does not affect public APIs - [x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.) - [x] This PR does not make changes to log messages (which monitoring infrastructure may rely on)
## Motivation Closes #2328 ## Changes For staging branch, i.e., for `bors merge` runs, use commithash rather than branch name (`staging`) as docker image tag to ensure that bors is running tests against the right code ## Test Plan N/A
Fix typo Spotter: @y0sher Bugfix to pass tests msgcon does not need its own closer. It's now closed from inside the UDP wrapper. Otherwise, we get a panic on trying to close a closed channel. Test that msgConn is closed on UDP conn eviction Mocks the msgConn in the test. Added a very simple interface to make this easier. Another test fix Need to init this channel manually in test Return conn token if incoming conn fails Spotter: @y0sher Formatting Add regression test for net max pending conn Fix merge conflicts and make linter happy Fix concurrency issue in test Linter Minor test cleanup Add shutdowns to tests
This reverts commit 2a33fd1.
lrettig
added a commit
that referenced
this pull request
Mar 31, 2021
Make linter happy Count abstain on zero pattern as explicit support Whitespace Revert "Calculate net not absolute tortoise support" This reverts commit 2a33fd1. Bugfix in sendMessage Bugfix Bugfix Fix test
lrettig
added a commit
that referenced
this pull request
Apr 1, 2021
Make linter happy Count abstain on zero pattern as explicit support Whitespace Revert "Calculate net not absolute tortoise support" This reverts commit 2a33fd1. Bugfix in sendMessage Bugfix Bugfix Fix test
|
This was included in the testnet branch in 632b6d6 and won't be included in develop since the ninja tortoise code has been deprecated. Closing. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Address an issue in #2298. Blocks can abstain now when hare fails, but empty layers aren't being finalized.
To do
Changes