-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweak tortoise vote calculation for testnet #2337
Commits on Mar 31, 2021
-
WIP: Contextual logging (#2323)
Fix merge conflicts, make lint happy Add context, improve debugging of syncer Context, logging for block listener, syncer Add context to hare outgoing messages Linter More lint and test fixes Fix merge conflicts Pass context down to msg send on net Improve net debug Improve context and logging for outgoing messages Improve context and logging for atx and block flow Remove explicit context and reqID from ReportValidation, and read from message context instead Resolves merge conflicts from testnet-126 branch changes Logging Minor cleanup of atx logging Bugfixes Add log context to fetch request Whitespace
Configuration menu - View commit details
-
Copy full SHA for 581a086 - Browse repository at this point
Copy the full SHA 581a086View commit details -
Vote for whole layer if hare results missing Lower tortoise thresholds for testnet Increase verbosity Vote for zero pattern instead Update test to match modified logic Improve log output Stick with old newly good threshold Minor test cleanup Make test more readable Update threshold and test Update votes, test passes Update second test to match new thresholds Cleanup threshold param Cleanup test Gofmt
Configuration menu - View commit details
-
Copy full SHA for 227a8b2 - Browse repository at this point
Copy the full SHA 227a8b2View commit details -
## Motivation It's confusing whether to click or not to click on the DevOps notes points. Re phrased them to make it clear. Co-authored-by: Lane Rettig <lanerettig@gmail.com> Co-authored-by: Anton Lerner <anton.lerner@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 8be68e4 - Browse repository at this point
Copy the full SHA 8be68e4View commit details -
Add SmesherID Index to Reward DB (#2262)
<!-- Please mention the issue fixed by this PR or detailed motivation --> Closes #2068 <!-- `Closes #XXXX, closes #XXXX, ...` links mentioned issues to this PR and automatically closes them when this it's merged --> <!-- Please describe in detail the changes made --> 1. Added `SmesherID` and `Coinbase` fields to `struct Reward` for efficient look-up. Used this to complete the `AccountDataQuery` and `AccountDataStream` endpoints in the API code. 2. Changed the database index for storing Rewards to a key of the form `reward_<coinbase>_<smesherID>_<layerID>` because multiple SmesherIDs could be associated with the same Coinbase. Added a secondary key for Rewards lookups by SmesherID. 3. Changed the `accumulateRewards` function in `mesh/mesh.go` so to support handling multiple smesherIDs associated with a single Coinbase. Moved event reporting of the Rewards from the processor to the mesh code. 4. Added tests to `mesh/meshdb_test.go` to test changes made. 5. Implemented the API endpoints for `SmesherRewardStream` and `SmesherDataQuery` using the endpoints created. 6. Since we now have that there can be multiple `SmesherID`s associated with a particular `Coinbase`, changed the way the rewards are calculated. Now the `blockTotalReward` and `blockLayerReward` are multiplied by the number of blocks produced by a particular `Coinbase`-`SmesherID` pair. <!-- Please specify how these changes were tested (e.g. unit tests, manual testing, etc.) --> Wrote multiple unit tests for both the APIs that I implemented, and the meshdb code that I changed. <!-- This section should be removed when all items are complete --> - [ ] Explain motivation or link existing issue(s) - [ ] Test changes and document test plan - [ ] Update documentation as needed Co-authored-by: Lane Rettig <lanerettig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b821ad4 - Browse repository at this point
Copy the full SHA b821ad4View commit details -
Fix fatal error in multi_node_sim (#2258)
## Motivation <!-- Please mention the issue fixed by this PR or detailed motivation --> Closes #2253 <!-- `Closes #XXXX, closes #XXXX, ...` links mentioned issues to this PR and automatically closes them when this it's merged --> ## Changes <!-- Please describe in detail the changes made --> - Fix fatal error in `multi_node_sim` ## Test Plan <!-- Please specify how these changes were tested (e.g. unit tests, manual testing, etc.) --> 1. Attempt to reproduce #2253 following steps from the PR description 2. There should be no fatal error
Configuration menu - View commit details
-
Copy full SHA for c9901ee - Browse repository at this point
Copy the full SHA c9901eeView commit details -
Remove a lingering reference to gitter from README Co-authored-by: Anton Lerner <anton.lerner@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for cc76ad3 - Browse repository at this point
Copy the full SHA cc76ad3View commit details -
Remove CI status badge from README (#2187)
## Motivation "CI status" for the develop branch is not really well-defined since we don't actually run any CI tasks on the develop branch. Bors runs them on staging, then merges to develop. If we set the status badge to develop, as it is now, it shows "no status." If we set it to staging, it'll show the status of the last bors run, which may have failed (and not been merged), which is misleading. @noamnelke you were right, I concede :)
Configuration menu - View commit details
-
Copy full SHA for 4c97ff0 - Browse repository at this point
Copy the full SHA 4c97ff0View commit details -
## Motivation Closes #2225 (obsoletes #2231) ## Changes Remove `Timestamp` field from the `BlockHeader` struct. ## Test Plan Unit tests have been updated and all pass consistently. System tests should be unaffected and will be run. ## DevOps Notes - [x] Does this code require configuration changes? ❌ - [x] Does this code affect public APIs? ❌ - [x] Does this code assume a new version of external services (PoET, elasticsearch, etc.) ❌ - [x] Does this code make changes to log messages that our monitoring infrastructure may rely on? ❌ Co-authored-by: Noam Nelke <noamnelke@gmail.com> Co-authored-by: Lane Rettig <lanerettig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c2c087c - Browse repository at this point
Copy the full SHA c2c087cView commit details -
replace FailNow in test with Panic (#2349)
## Motivation Fixes #2348 ## Changes - replace `t.FailNow()` in non-test goroutine with Panic ## Test Plan N/A ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [ ] Update documentation as needed ## DevOps Notes <!-- Please uncheck these items as applicable to make DevOps aware of changes that may affect releases --> - [x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources) - [x] This PR does not affect public APIs - [x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.) - [x] This PR does not make changes to log messages (which monitoring infrastructure may rely on)
Configuration menu - View commit details
-
Copy full SHA for 68d2807 - Browse repository at this point
Copy the full SHA 68d2807View commit details -
Use commithash as docker tag for staging (#2331)
## Motivation Closes #2328 ## Changes For staging branch, i.e., for `bors merge` runs, use commithash rather than branch name (`staging`) as docker image tag to ensure that bors is running tests against the right code ## Test Plan N/A
Configuration menu - View commit details
-
Copy full SHA for 4175cf8 - Browse repository at this point
Copy the full SHA 4175cf8View commit details -
WIP: Fix memory leaks in p2p (#2351)
Fix typo Spotter: @y0sher Bugfix to pass tests msgcon does not need its own closer. It's now closed from inside the UDP wrapper. Otherwise, we get a panic on trying to close a closed channel. Test that msgConn is closed on UDP conn eviction Mocks the msgConn in the test. Added a very simple interface to make this easier. Another test fix Need to init this channel manually in test Return conn token if incoming conn fails Spotter: @y0sher Formatting Add regression test for net max pending conn Fix merge conflicts and make linter happy Fix concurrency issue in test Linter Minor test cleanup Add shutdowns to tests
Configuration menu - View commit details
-
Copy full SHA for e45462d - Browse repository at this point
Copy the full SHA e45462dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a33fd1 - Browse repository at this point
Copy the full SHA 2a33fd1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4418891 - Browse repository at this point
Copy the full SHA 4418891View commit details -
Configuration menu - View commit details
-
Copy full SHA for ae78a56 - Browse repository at this point
Copy the full SHA ae78a56View commit details -
Configuration menu - View commit details
-
Copy full SHA for ac94e26 - Browse repository at this point
Copy the full SHA ac94e26View commit details -
Revert "Calculate net not absolute tortoise support"
This reverts commit 2a33fd1.
Configuration menu - View commit details
-
Copy full SHA for d7ae35c - Browse repository at this point
Copy the full SHA d7ae35cView commit details -
Configuration menu - View commit details
-
Copy full SHA for d8a8d85 - Browse repository at this point
Copy the full SHA d8a8d85View commit details -
Configuration menu - View commit details
-
Copy full SHA for c7d1538 - Browse repository at this point
Copy the full SHA c7d1538View commit details -
Configuration menu - View commit details
-
Copy full SHA for ccacb08 - Browse repository at this point
Copy the full SHA ccacb08View commit details -
Configuration menu - View commit details
-
Copy full SHA for cbf2387 - Browse repository at this point
Copy the full SHA cbf2387View commit details