Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Fix caching malfeasance info in atxsdata store #5932

Closed
wants to merge 2 commits into from

Conversation

poszu
Copy link
Contributor

@poszu poszu commented May 13, 2024

Motivation

Hare depends on atxsdata to check whether a smesher is considered malicious.

Description

Reverts part of https://github.com/spacemeshos/go-spacemesh/pull/5806/files#diff-d76a0e23ae1b705f6e5c33771a285f819b03a3bac7661fdbf3e34b3b9bdbda76 change

Test Plan

Added unit tests and documentation specifying the purpose of atxsdata in CachedDB.

TODO

  • Explain motivation or link existing issue(s)
  • Test changes and document test plan
  • Update documentation as needed
  • Update changelog as needed

@poszu
Copy link
Contributor Author

poszu commented May 13, 2024

bors merge

spacemesh-bors bot pushed a commit that referenced this pull request May 13, 2024
## Motivation

Hare depends on `atxsdata` to check whether a smesher is considered malicious.
Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.7%. Comparing base (2452f59) to head (55188f5).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff           @@
##           develop   #5932   +/-   ##
=======================================
  Coverage     80.7%   80.7%           
=======================================
  Files          288     288           
  Lines        29890   29895    +5     
=======================================
+ Hits         24145   24153    +8     
+ Misses        4157    4155    -2     
+ Partials      1588    1587    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@spacemesh-bors
Copy link

Build failed:

  • ci-status

@poszu
Copy link
Contributor Author

poszu commented May 13, 2024

bors merge

spacemesh-bors bot pushed a commit that referenced this pull request May 13, 2024
## Motivation

Hare depends on `atxsdata` to check whether a smesher is considered malicious.
@spacemesh-bors
Copy link

Build failed:

@poszu
Copy link
Contributor Author

poszu commented May 13, 2024

TestPartition_50_50 hang. bors merge

@poszu
Copy link
Contributor Author

poszu commented May 13, 2024

bors merge

spacemesh-bors bot pushed a commit that referenced this pull request May 13, 2024
## Motivation

Hare depends on `atxsdata` to check whether a smesher is considered malicious.
@spacemesh-bors
Copy link

Pull request successfully merged into develop.

Build succeeded:

@spacemesh-bors spacemesh-bors bot changed the title Fix caching malfeasance info in atxsdata store [Merged by Bors] - Fix caching malfeasance info in atxsdata store May 13, 2024
@spacemesh-bors spacemesh-bors bot closed this May 13, 2024
@spacemesh-bors spacemesh-bors bot deleted the fix/caching-malfeasance branch May 13, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants