[Merged by Bors] - api: v2alpha1: ATX improvements and sort order filter #6059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kacpersaw
commented
Jun 21, 2024
kacpersaw
commented
- Add NumUnits to Activation message
- Change name of NodeId filter to SmesherId.
- Modify Id to allow multiple entries.
- Remove signature and previous_atx from Activation message
- Update stream filters to match list filters
- Add sort_order field to tx, layer and reward List requests
kacpersaw
requested review from
dshulyak,
fasmat,
poszu,
ivan4th and
acud
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6059 +/- ##
=======================================
Coverage 81.4% 81.4%
=======================================
Files 299 299
Lines 32172 32171 -1
=======================================
+ Hits 26205 26214 +9
+ Misses 4252 4246 -6
+ Partials 1715 1711 -4 ☔ View full report in Codecov by Sentry. |
poszu
reviewed
Jun 21, 2024
Co-authored-by: Bartosz Różański <bartek.roza@gmail.com>
poszu
approved these changes
Jun 21, 2024
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Jun 21, 2024
* Add NumUnits to Activation message * Change name of NodeId filter to SmesherId. * Modify Id to allow multiple entries. * Remove signature and previous_atx from Activation message * Update stream filters to match list filters * Add sort_order field to tx, layer and reward List requests
|
Pull request successfully merged into develop. Build succeeded:
|
spacemesh-bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.