This repository has been archived by the owner on Aug 14, 2023. It is now read-only.
Use Rust 2021 edition (new feature resolver!) #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kobby-pentangeli
approved these changes
Nov 21, 2021
There was a problem hiding this comment.
Since this is a separate PR, I'm reiterating this suggestion here as well:
Unless there are explicit reasons otherwise, I suggest we .gitignore the following files:
CallDataTemplate-meta.json,Cargo.lock(especially since this is a library and not a binary), andruntime_calldata.wasm.
YaronWittenstein
approved these changes
Nov 22, 2021
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up PR to #417. Now that most Cargo feature conflicts are gone (only some work on
static-allocanddynamic-allocis missing, but these two feature flags turned out to be the less problematic among all, so I've prioritizedffiandmock), we can use the 2021 Rust edition without issues.