-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HlA-1059: Reference catalog weights corrected #1616
HlA-1059: Reference catalog weights corrected #1616
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1616 +/- ##
==========================================
+ Coverage 32.36% 32.39% +0.02%
==========================================
Files 159 159
Lines 35053 35056 +3
==========================================
+ Hits 11345 11355 +10
+ Misses 23708 23701 -7
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since SCSB only has a general set of standards (https://innerspace.stsci.edu/display/SCSB/Code+standards+refresher), and not a specific package we are supposed to use, I have tried to keep my opinion to myself. However, there are a few places where I found the Black code updates to make the code harder to parse. Please address these few items.
@s-goldman Where is the update to the "wfpc2_wfpc2_index.json"? |
@s-goldman Oops. I was checking both your PRs and made a comment in the wrong PR. The change to the parameter index file needs to be in PR#1052 and not this PR for proper tracking of history. Please remove the changes for config_utils.py from this PR and put into PR#1052. Once that is done, this PR is ready to go. |
I'm sorry, I should have caught that. The change to config_utils is now in the HLA-1052 PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the fixes!
This PR corrects the weighting of the reference catalogs; the code now uses 1/sigma**2. The important lines of code are 283 and 284. I also added line 281 to avoid a possible divide by zero error. The remaining changes are the result of code formatting (black).