Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes codecov #1816

Merged
merged 2 commits into from
Jun 13, 2024
Merged

Fixes codecov #1816

merged 2 commits into from
Jun 13, 2024

Conversation

jhunkeler
Copy link
Contributor

  • Fixes missing python 3.11 test commands

@jhunkeler jhunkeler requested review from mdlpstsci and a team as code owners June 13, 2024 18:58
@jhunkeler
Fixes codecov
9dd3cba 
* Fixes missing python 3.11 test commands
mdlpstsci
mdlpstsci reviewed Jun 13, 2024
View reviewed changes
JenkinsfileRT Outdated
@@ -60,6 +64,9 @@ bc3.conda_packages = ['python=3.11']
bc3.build_cmds = ["pip install numpy astropy ci-watson",
"pip install --upgrade -e '.[test]'",
"pip freeze"]
bc2.test_cmds = ["pytest --env=${artifactory_env} --cov=./ --basetemp=tests_output --junitxml=results.xml --bigdata",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be "b3" instead of "b2"?

mdlpstsci
mdlpstsci requested changes Jun 13, 2024
View reviewed changes
Copy link
Collaborator

@mdlpstsci mdlpstsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chastised for not leaving a comment. I believe the "b2" should be "b3" on or around line 67.

@mdlpstsci mdlpstsci merged commit 3bbd3da into spacetelescope:main Jun 13, 2024
14 of 15 checks passed
mdlpstsci pushed a commit to mdlpstsci/drizzlepac that referenced this pull request Jun 13, 2024
@jhunkeler @mdlpstsci
Fixes codecov (spacetelescope#1816)
b3b2f8c
@s-goldman
Copy link
Collaborator

It looks like we also need to pip install pytest-cov in order for the --cov command to work for the 3.11 test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdlpstsci mdlpstsci mdlpstsci approved these changes

Assignees
No one assigned
Labels
bug testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jhunkeler @s-goldman @mdlpstsci