Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix CRDS_PATH in CI when running downstream tests #432

Merged
merged 1 commit into from
Dec 23, 2022

Conversation

zacharyburnett
Copy link
Collaborator

@zacharyburnett zacharyburnett commented Dec 23, 2022

This fixes the issue where the downstream tests fail because the CRDS_PATH variable is not correctly passed to the toxenv: https://github.com/spacetelescope/gwcs/actions/runs/3766847233/jobs/6404085866

@codecov
Copy link

codecov bot commented Dec 23, 2022

Codecov Report

Base: 86.93% // Head: 86.93% // No change to project coverage 👍

Coverage data is based on head (b42acb0) compared to base (dcf4f98).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #432   +/-   ##
=======================================
  Coverage   86.93%   86.93%           
=======================================
  Files          25       25           
  Lines        3888     3888           
=======================================
  Hits         3380     3380           
  Misses        508      508           
Flag Coverage Δ
unit 86.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zacharyburnett zacharyburnett changed the title use relative path for crds cache in ci fix CRDS_PATH in CI when running downstream tests Dec 23, 2022
@zacharyburnett zacharyburnett marked this pull request as ready for review December 23, 2022 17:37
@zacharyburnett zacharyburnett merged commit 2062cfb into spacetelescope:master Dec 23, 2022
@zacharyburnett zacharyburnett deleted the crds_path branch December 23, 2022 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants