Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLA-1133: DO NOT MERGE (TESTING) - CALACS Serial CTE Correction #601

Closed
wants to merge 11 commits into from

Conversation

mdlpstsci
Copy link
Contributor

Reorganized docte.c to control the imset and amp looping
so the dopcte-gen2.c code handles the actual CTE serial
and parallel corrections. The amp-based serial CTE
correction values are read only when needed in the "amp"
loop. In dopcte-gen2.c re-used code which performed a
top-to-bottom flip by creating a new function as now a
top-to-bottom flip is done in multiple places, as well
as a side-to-side flip, to accommodate clockwise and
counterclockwise rotations. The OpenMP directives have
not been changed so far.

so the dopcte-gen2.c code handles the actual CTE serial
and parallel corrections.  The amp-based serial CTE
correction values are read only when needed in the "amp"
loop. In dopcte-gen2.c re-used code which performed a
top-to-bottom flip by creating a new function as now a
top-to-bottom flip is done in multiple places, as well
as a side-to-side flip, to accommodate clockwise and
counterclockwise rotations. The OpenMP directives have
not been changed so far.
PCTETAB which not only has four extansions supporting the serial
correction for each amp, but some of the keywords originally
read from the PHDU are now also amp-dependent and exist in the
QPROF extension corresponding to each amp.
other portions of ACS pipeline.  It was only necessary to delete
the function which performed the CTE Version 1 from this file.
first.  Only then should the data be flipped from side-to-side
or top-to-bottom to complete the rotation.
@mdlpstsci
Copy link
Contributor Author

This PR has be superseded by PR#609.

@mdlpstsci mdlpstsci closed this Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant