-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HLA-1133: DO NOT MERGE (TESTING) - CALACS Serial CTE Correction #601
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for controlling parallel CTE.
so the dopcte-gen2.c code handles the actual CTE serial and parallel corrections. The amp-based serial CTE correction values are read only when needed in the "amp" loop. In dopcte-gen2.c re-used code which performed a top-to-bottom flip by creating a new function as now a top-to-bottom flip is done in multiple places, as well as a side-to-side flip, to accommodate clockwise and counterclockwise rotations. The OpenMP directives have not been changed so far.
PCTETAB which not only has four extansions supporting the serial correction for each amp, but some of the keywords originally read from the PHDU are now also amp-dependent and exist in the QPROF extension corresponding to each amp.
other portions of ACS pipeline. It was only necessary to delete the function which performed the CTE Version 1 from this file.
first. Only then should the data be flipped from side-to-side or top-to-bottom to complete the rotation.
is done for the parallel CTE parameters.
This PR has be superseded by PR#609. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reorganized docte.c to control the imset and amp looping
so the dopcte-gen2.c code handles the actual CTE serial
and parallel corrections. The amp-based serial CTE
correction values are read only when needed in the "amp"
loop. In dopcte-gen2.c re-used code which performed a
top-to-bottom flip by creating a new function as now a
top-to-bottom flip is done in multiple places, as well
as a side-to-side flip, to accommodate clockwise and
counterclockwise rotations. The OpenMP directives have
not been changed so far.