Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix devdeps #2905

Merged
merged 2 commits into from
Jun 4, 2024
Merged

Fix devdeps #2905

merged 2 commits into from
Jun 4, 2024

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Jun 3, 2024

Description

Compatibility patch with the following upstream changes:

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)? 🐱 🐱

@pllim pllim added this to the 4.0 milestone Jun 3, 2024
@github-actions github-actions bot added cubeviz testing imviz plugin Label for plugins common to multiple configurations labels Jun 3, 2024
@pllim pllim added the no-changelog-entry-needed changelog bot directive label Jun 3, 2024
Copy link

codecov bot commented Jun 3, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.76%. Comparing base (07cc0f3) to head (ea71dfc).
Report is 145 commits behind head on main.

Files with missing lines Patch % Lines
...configs/cubeviz/plugins/moment_maps/moment_maps.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2905      +/-   ##
==========================================
- Coverage   88.76%   88.76%   -0.01%     
==========================================
  Files         111      111              
  Lines       17172    17178       +6     
==========================================
+ Hits        15243    15248       +5     
- Misses       1929     1930       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pllim pllim modified the milestones: 4.0, 3.10.2 Jun 3, 2024
@pllim pllim added the 💤backport-v3.10.x on-merge: backport to v3.10.x label Jun 3, 2024
@pllim pllim marked this pull request as ready for review June 3, 2024 21:48
@pllim pllim requested a review from larrybradley June 3, 2024 21:55
Copy link
Collaborator

@rosteen rosteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@pllim
Copy link
Contributor Author

pllim commented Jun 4, 2024

@larrybradley , do you also want to review since a couple of the tests are due to photutils?

Copy link
Member

@larrybradley larrybradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The photutils-related changes look good to me. Thanks.

@pllim pllim merged commit 1733f43 into spacetelescope:main Jun 4, 2024
23 of 24 checks passed
@pllim pllim deleted the update-test-results branch June 4, 2024 18:15

This comment was marked as resolved.

@pllim pllim modified the milestones: 3.10.2, 3.11 Jun 4, 2024
@pllim pllim removed Still Needs Manual Backport 💤backport-v3.10.x on-merge: backport to v3.10.x labels Jun 4, 2024
@pllim

This comment was marked as outdated.

pllim added a commit to pllim/jdaviz that referenced this pull request Jun 4, 2024
but only for photutils changes
@pllim pllim added the 💤backport-v3.10.x on-merge: backport to v3.10.x label Jun 4, 2024
@pllim pllim modified the milestones: 3.11, 3.10.2 Jun 4, 2024
@pllim
Copy link
Contributor Author

pllim commented Jun 4, 2024

Nvm I cannot let it go #2908

pllim added a commit to pllim/jdaviz that referenced this pull request Jun 4, 2024
but only for photutils changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cubeviz imviz no-changelog-entry-needed changelog bot directive plugin Label for plugins common to multiple configurations testing 💤backport-v3.10.x on-merge: backport to v3.10.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants